feat: enhance diagnostics structure with nodeId and parameterIndex for better error tracking

Author: nicosammito

src/utils.ts

@@ -18,9 +18,11 @@ export interface ValidationResult {
     isValid: boolean;
     returnType: string;
     diagnostics: Array<{
-        message: string;
-        code: number;
-        severity: "error" | "warning";
+        message: string
+        code: number
+        severity: "error" | "warning"
+        nodeId?: NodeFunction["id"]
+        parameterIndex?: number
     }>;
 }
 

src/validation/getNodeValidation.ts

@@ -30,7 +30,7 @@ export const getNodeValidation = (
         return {
             isValid: false,
             returnType: "any",
-            diagnostics: [{message: `Function ${node.id} not found`, code: 404, severity: "error"}],
+            diagnostics: [{message: `Function ${node.id} not found`, nodeId: node.id, code: 404, severity: "error"}],
         };
     }
 
@@ -46,6 +46,8 @@ export const getNodeValidation = (
                 scopeErrors.push({
                     message: validation.error || "Scope error",
                     code: 403,
+                    nodeId: node.id,
+                    parameterIndex: params.indexOf(param),
                     severity: "error"
                 });
             }
@@ -114,6 +116,16 @@ export const getNodeValidation = (
         return {
             message,
             code: d.code,
+            nodeId: node.id,
+            parameterIndex: (() => {
+                if (d.start !== undefined) {
+                    const argIndex = params.findIndex((_, i) => {
+                        const start = sourceCode.indexOf(paramCodes[i]);
+                        return d.start! >= start && d.start! < start + paramCodes[i].length;
+                    });
+                    if (argIndex !== -1) return argIndex;
+                }
+            })(),
             severity: (isGenericPlaceholder || isMockError ? "warning" : "error") as "error" | "warning",
         };
     });

test/data.ts

@@ -26,6 +26,16 @@ export const DATA_TYPES: DataType[] = [
  */
 export const FUNCTION_SIGNATURES: FunctionDefinition[] = [
     {
+        parameterDefinitions: {
+            nodes: [
+                {
+                    identifier: "list"
+                },
+                {
+                    identifier: "index"
+                }
+            ]
+        },
         signature: "<R>(list: LIST<R>, index: NUMBER): R",
         identifier: "std::list::at",
     },

test/nodeValidation.test.ts

@@ -93,6 +93,7 @@ describe('getNodeValidation', () => {
 
     it('3', () => {
         const result = getNodeValidation({}, {
+            id: "gid://sagittarius/NodeFunction/1",
             functionDefinition: {
                 identifier: "std::list::at" as any
             },