refactor: enhance parameterIndex handling in getFlowValidation.ts for better safety checks

nicosammito · nicosammito · commit 9fe3f653b029 · 2026-04-14T17:20:52.000+02:00
diff --git a/src/validation/getFlowValidation.ts b/src/validation/getFlowValidation.ts
@@ -63,7 +63,7 @@ export const getFlowValidation = (
 
             if (closestMatch) {
                 nodeId = closestMatch[1] === "null" ? null : closestMatch[1] as NodeFunction['id'];
-                parameterIndex = parseInt(closestMatch[2], 10) || null;
+                parameterIndex = parseInt(closestMatch[2], 10);
             }
         }
 
@@ -72,7 +72,7 @@ export const getFlowValidation = (
             code: d.code,
             severity: "error" as const,
             nodeId,
-            parameterIndex
+            parameterIndex: typeof parameterIndex == "number" && Number.isSafeInteger(parameterIndex) ? parameterIndex : null,
         };
     }).filter((e) => e !== null);
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ export const getFlowValidation = (`
`63`	`63`
`64`	`64`	`if (closestMatch) {`
`65`	`65`	`nodeId = closestMatch[1] === "null" ? null : closestMatch[1] as NodeFunction['id'];`
`66`		`- parameterIndex = parseInt(closestMatch[2], 10) \|\| null;`
	`66`	`+ parameterIndex = parseInt(closestMatch[2], 10);`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`
`@@ -72,7 +72,7 @@ export const getFlowValidation = (`
`72`	`72`	`code: d.code,`
`73`	`73`	`severity: "error" as const,`
`74`	`74`	`nodeId,`
`75`		`- parameterIndex`
	`75`	`+ parameterIndex: typeof parameterIndex == "number" && Number.isSafeInteger(parameterIndex) ? parameterIndex : null,`
`76`	`76`	`};`
`77`	`77`	`}).filter((e) => e !== null);`
`78`	`78`