feat: rename errors to diagnostics for improved clarity in validation results

Author: nicosammito

src/utils.ts

@@ -17,7 +17,7 @@ import {createSystem, createVirtualTypeScriptEnvironment, VirtualTypeScriptEnvir
 export interface ValidationResult {
     isValid: boolean;
     returnType: string;
-    errors: Array<{
+    diagnostics: Array<{
         message: string;
         code: number;
         severity: "error" | "warning";

src/validation/getFlowValidation.ts

@@ -131,6 +131,6 @@ export const getFlowValidation = (
     return {
         isValid: !errors.some(e => e?.severity === "error"),
         returnType: "void",
-        errors,
+        diagnostics: errors,
     };
 };

src/validation/getNodeValidation.ts

@@ -30,12 +30,12 @@ export const getNodeValidation = (
         return {
             isValid: false,
             returnType: "any",
-            errors: [{message: `Function ${node.id} not found`, code: 404, severity: "error"}],
+            diagnostics: [{message: `Function ${node.id} not found`, code: 404, severity: "error"}],
         };
     }
 
     const params = (node.parameters?.nodes as NodeParameter[]) || [];
-    const scopeErrors: ValidationResult["errors"] = [];
+    const scopeErrors: ValidationResult["diagnostics"] = [];
 
     // 1. Parameter scope validation
     for (const param of params) {
@@ -56,7 +56,7 @@ export const getNodeValidation = (
         return {
             isValid: false,
             returnType: "any",
-            errors: scopeErrors,
+            diagnostics: scopeErrors,
         };
     }
 
@@ -121,6 +121,6 @@ export const getNodeValidation = (
     return {
         isValid: !errors.some(e => e.severity === "error"),
         returnType: inferredType,
-        errors,
+        diagnostics: errors,
     };
 };

src/validation/getValueValidation.ts

@@ -41,6 +41,6 @@ export const getValueValidation = (
     return {
         isValid: !errors.some(e => e.severity === "error"),
         returnType: "void",
-        errors,
+        diagnostics: errors,
     };
 };

test/flowValidation.test.ts

@@ -67,7 +67,7 @@ describe('getFlowValidation - Integrationstest', () => {
         const result = getFlowValidation(flow, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(true);
-        expect(result.errors).toHaveLength(0);
+        expect(result.diagnostics).toHaveLength(0);
     });
 
     it('sollte einen komplexen Flow mit verschachtelten Scopes und Generics validieren', () => {
@@ -110,7 +110,7 @@ describe('getFlowValidation - Integrationstest', () => {
         const result = getFlowValidation(flow, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(true);
-        expect(result.errors).toHaveLength(0);
+        expect(result.diagnostics).toHaveLength(0);
     });
 
 });

test/nodeValidation.test.ts

@@ -24,7 +24,7 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
         expect(result.isValid).toBe(true);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBe(0);
     })
 
     it('2', () => {
@@ -88,7 +88,7 @@ describe('getNodeValidation', () => {
 
         expect(result.isValid).toBe(true);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBe(0);
     })
 
     it('3', () => {
@@ -113,7 +113,7 @@ describe('getNodeValidation', () => {
 
         expect(result.isValid).toBe(false);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBeGreaterThan(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBeGreaterThan(0);
     })
 
     it('4', () => {
@@ -180,7 +180,7 @@ describe('getNodeValidation', () => {
 
         expect(result.isValid).toBe(true);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBe(0);
     })
 
     it('5', () => {
@@ -253,7 +253,7 @@ describe('getNodeValidation', () => {
 
         expect(result.isValid).toBe(true);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBe(0);
     })
 
     it('6', () => {
@@ -321,7 +321,7 @@ describe('getNodeValidation', () => {
 
         expect(result.isValid).toBe(true);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBe(0);
     })
 
     it('7', () => {
@@ -365,7 +365,7 @@ describe('getNodeValidation', () => {
         expect(result.isValid).toBe(true);
         expect(result.returnType).toBe("number");
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBe(0);
     })
 
     it('8', () => {
@@ -408,7 +408,7 @@ describe('getNodeValidation', () => {
 
         expect(result.isValid).toBe(false);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBeGreaterThan(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBeGreaterThan(0);
     })
 
     it('9', () => {
@@ -451,7 +451,7 @@ describe('getNodeValidation', () => {
 
         expect(result.isValid).toBe(true);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBe(0);
     })
 
     it('10', () => {
@@ -513,7 +513,7 @@ describe('getNodeValidation', () => {
 
         expect(result.isValid).toBe(true);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBe(0);
     })
 
     it('11', () => {
@@ -583,7 +583,7 @@ describe('getNodeValidation', () => {
 
         expect(result.isValid).toBe(true);
         expect(result.returnType).toBeDefined();
-        expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
+        expect(result.diagnostics.filter(e => e.severity === 'error').length).toBe(0);
     })
 
 });