feat: rename Error message to ServiceError and update related fields in response messages

nicosammito · nicosammito · commit 37f14694cc8b · 2026-04-24T00:49:40.000+02:00
diff --git a/proto/sagittarius/sagittarius.module.proto b/proto/sagittarius/sagittarius.module.proto
@@ -17,7 +17,7 @@ message ModuleUpdateRequest {
 message ModuleUpdateResponse {
   // True if was successful, false if not
   bool success = 1;
-  optional shared.Error error = 2;
+  optional shared.ServiceError error = 2;
 }
 
 //This service will be implemented as a server by Sagittarius and as a client by Aquila.
diff --git a/proto/sagittarius/sagittarius.runtime_status.proto b/proto/sagittarius/sagittarius.runtime_status.proto
@@ -17,7 +17,7 @@ message RuntimeStatusUpdateRequest {
 
 message RuntimeStatusUpdateResponse {
   bool success = 1;
-  optional shared.Error error = 2;
+  optional shared.ServiceError error = 2;
 }
 
 service RuntimeStatusService {
diff --git a/proto/sagittarius/sagittarius.runtime_usage.proto b/proto/sagittarius/sagittarius.runtime_usage.proto
@@ -13,7 +13,7 @@ message RuntimeUsageRequest {
 
 message RuntimeUsageResponse {
   bool success = 1;
-  optional shared.Error error = 2;
+  optional shared.ServiceError error = 2;
 }
 
 service RuntimeUsageService {
diff --git a/proto/shared/shared.errors.proto b/proto/shared/shared.errors.proto
@@ -4,18 +4,18 @@ package shared;
 
 option ruby_package = "Tucana::Shared";
 
-message Error {
+message ServiceError {
   string message = 1;
-  repeated ErrorDetails details = 2;
+  repeated ServiceErrorDetails details = 2;
 }
 
-message ErrorDetails {
+message ServiceErrorDetails {
   oneof kind {
-    ActiveModelError active_model_error = 1;
+    ServiceActiveModelError active_model_error = 1;
   }
 }
 
-message ActiveModelError {
+message ServiceActiveModelError {
   string attribute = 1;
   string type = 2;
 }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ message ModuleUpdateRequest {`
`17`	`17`	`message ModuleUpdateResponse {`
`18`	`18`	`// True if was successful, false if not`
`19`	`19`	`bool success = 1;`
`20`		`- optional shared.Error error = 2;`
	`20`	`+ optional shared.ServiceError error = 2;`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`//This service will be implemented as a server by Sagittarius and as a client by Aquila.`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ message RuntimeStatusUpdateRequest {`
`17`	`17`
`18`	`18`	`message RuntimeStatusUpdateResponse {`
`19`	`19`	`bool success = 1;`
`20`		`- optional shared.Error error = 2;`
	`20`	`+ optional shared.ServiceError error = 2;`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`service RuntimeStatusService {`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ message RuntimeUsageRequest {`
`13`	`13`
`14`	`14`	`message RuntimeUsageResponse {`
`15`	`15`	`bool success = 1;`
`16`		`- optional shared.Error error = 2;`
	`16`	`+ optional shared.ServiceError error = 2;`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`service RuntimeUsageService {`
Original file line number	Diff line number	Diff line change
`@@ -4,18 +4,18 @@ package shared;`
`4`	`4`
`5`	`5`	`option ruby_package = "Tucana::Shared";`
`6`	`6`
`7`		`-message Error {`
	`7`	`+message ServiceError {`
`8`	`8`	`string message = 1;`
`9`		`- repeated ErrorDetails details = 2;`
	`9`	`+ repeated ServiceErrorDetails details = 2;`
`10`	`10`	`}`
`11`	`11`
`12`		`-message ErrorDetails {`
	`12`	`+message ServiceErrorDetails {`
`13`	`13`	`oneof kind {`
`14`		`- ActiveModelError active_model_error = 1;`
	`14`	`+ ServiceActiveModelError active_model_error = 1;`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`
`18`		`-message ActiveModelError {`
	`18`	`+message ServiceActiveModelError {`
`19`	`19`	`string attribute = 1;`
`20`	`20`	`string type = 2;`
`21`	`21`	`}`