Merge pull request #260 from code0-tech/214-flowtype-datatype-and-runtimefunctionservices-need-proper-errors

Add detailed errors to update requests

Author: raphael-goetz

proto/sagittarius/sagittarius.action_configuration.proto

@@ -5,6 +5,7 @@ option ruby_package = "Tucana::Sagittarius";
 package sagittarius;
 
 import "shared.action_configuration.proto";
+import "shared.errors.proto";
 
 // Request for updating a action configuration
 message ActionConfigurationUpdateRequest {
@@ -18,6 +19,7 @@ message ActionConfigurationUpdateRequest {
 message ActionConfigurationUpdateResponse {
   // True if was successful, false if not
   bool success = 1;
+  optional shared.Error error = 2;
 }
 
 service ActionConfigurationService {

proto/sagittarius/sagittarius.data_type.proto

@@ -5,6 +5,7 @@ option ruby_package = "Tucana::Sagittarius";
 package sagittarius;
 
 import "shared.data_type.proto";
+import "shared.errors.proto";
 
 // Request for updating a data type
 message DataTypeUpdateRequest {
@@ -16,6 +17,7 @@ message DataTypeUpdateRequest {
 message DataTypeUpdateResponse {
   // True if was successful, false if not
   bool success = 1;
+  optional shared.Error error = 2;
 }
 
 service DataTypeService {

proto/sagittarius/sagittarius.flow_type.proto

@@ -4,6 +4,7 @@ option ruby_package = "Tucana::Sagittarius";
 
 package sagittarius;
 
+import "shared.errors.proto";
 import "shared.flow_definition.proto";
 
 // Request for updating a list of adapter flow types
@@ -16,6 +17,7 @@ message FlowTypeUpdateRequest {
 message FlowTypeUpdateResponse {
   // True if was successful, false if not
   bool success = 1;
+  optional shared.Error error = 2;
 }
 
 //This service will be implemented as a server by Sagittarius and as a client by Aquila.

proto/sagittarius/sagittarius.function.proto

@@ -4,6 +4,7 @@ option ruby_package = "Tucana::Sagittarius";
 
 package sagittarius;
 
+import "shared.errors.proto";
 import "shared.function.proto";
 
 // Request for updating a list of function definitions
@@ -16,6 +17,7 @@ message FunctionDefinitionUpdateRequest {
 message FunctionDefinitionUpdateResponse {
   // True if was successful, false if not
   bool success = 1;
+  optional shared.Error error = 2;
 }
 
 //This service will be implemented as a server by Sagittarius and as a client by Aquila.

proto/sagittarius/sagittarius.runtime_function.proto

@@ -4,6 +4,7 @@ option ruby_package = "Tucana::Sagittarius";
 
 package sagittarius;
 
+import "shared.errors.proto";
 import "shared.runtime_function.proto";
 
 // Request for updating a list of runtime function definitions
@@ -16,6 +17,7 @@ message RuntimeFunctionDefinitionUpdateRequest {
 message RuntimeFunctionDefinitionUpdateResponse {
   // True if was successful, false if not
   bool success = 1;
+  optional shared.Error error = 2;
 }
 
 //This service will be implemented as a server by Sagittarius and as a client by Aquila.

proto/sagittarius/sagittarius.runtime_status.proto

@@ -2,6 +2,7 @@ syntax = "proto3";
 
 package sagittarius;
 
+import "shared.errors.proto";
 import "shared.runtime_status.proto";
 
 option ruby_package = "Tucana::Sagittarius";
@@ -16,6 +17,7 @@ message RuntimeStatusUpdateRequest {
 
 message RuntimeStatusUpdateResponse {
   bool success = 1;
+  optional shared.Error error = 2;
 }
 
 service RuntimeStatusService {

proto/sagittarius/sagittarius.runtime_usage.proto

@@ -2,6 +2,7 @@ syntax = "proto3";
 
 package sagittarius;
 
+import "shared.errors.proto";
 import "shared.runtime_usage.proto";
 
 option ruby_package = "Tucana::Sagittarius";
@@ -12,6 +13,7 @@ message RuntimeUsageRequest {
 
 message RuntimeUsageResponse {
   bool success = 1;
+  optional shared.Error error = 2;
 }
 
 service RuntimeUsageService {

proto/shared/shared.errors.proto

@@ -0,0 +1,21 @@
+syntax = "proto3";
+
+package shared;
+
+option ruby_package = "Tucana::Shared";
+
+message Error {
+  string message = 1;
+  repeated ErrorDetails details = 2;
+}
+
+message ErrorDetails {
+  oneof kind {
+    ActiveModelError active_model_error = 1;
+  }
+}
+
+message ActiveModelError {
+  string attribute = 1;
+  string type = 2;
+}