lint

Author: tstromberg

.golangci.yml

@@ -128,6 +128,7 @@ linters:
       enable-all: true
       disabled-checks:
         - paramTypeCombine
+        - rangeValCopy # PRSummary struct (152 bytes) copies are acceptable for code clarity
       # The list of supported checkers can be found at https://go-critic.com/overview.
       settings:
         captLocal:

cmd/prcost/repository.go

@@ -15,11 +15,14 @@ import (
 // Uses library functions from pkg/github and pkg/cost for fetching, sampling,
 // and extrapolation - all functionality is available to external clients.
 func analyzeRepository(ctx context.Context, owner, repo string, sampleSize, days int, cfg cost.Config, token, dataSource string) error {
+	// Create GitHub client without caching (for CLI)
+	client := github.NewClientWithoutCache()
+
 	// Calculate since date
 	since := time.Now().AddDate(0, 0, -days)
 
 	// Fetch all PRs modified since the date using library function
-	prs, _, err := github.FetchPRsFromRepo(ctx, owner, repo, since, token, nil)
+	prs, err := client.FetchPRsFromRepo(ctx, owner, repo, since, token, nil)
 	if err != nil {
 		return fmt.Errorf("failed to fetch PRs: %w", err)
 	}
@@ -93,7 +96,7 @@ func analyzeRepository(ctx context.Context, owner, repo string, sampleSize, days
 	totalAuthors := github.CountUniqueAuthors(prs)
 
 	// Query for actual count of open PRs (not extrapolated from samples)
-	openPRCount, err := github.CountOpenPRsInRepo(ctx, owner, repo, token)
+	openPRCount, err := client.CountOpenPRsInRepo(ctx, owner, repo, token)
 	if err != nil {
 		slog.Warn("Failed to count open PRs, using 0", "error", err)
 		openPRCount = 0
@@ -128,13 +131,16 @@ func analyzeRepository(ctx context.Context, owner, repo string, sampleSize, days
 // Uses library functions from pkg/github and pkg/cost for fetching, sampling,
 // and extrapolation - all functionality is available to external clients.
 func analyzeOrganization(ctx context.Context, org string, sampleSize, days int, cfg cost.Config, token, dataSource string) error {
+	// Create GitHub client without caching (for CLI)
+	client := github.NewClientWithoutCache()
+
 	slog.Info("Fetching PR list from organization")
 
 	// Calculate since date
 	since := time.Now().AddDate(0, 0, -days)
 
 	// Fetch all PRs across the org modified since the date using library function
-	prs, _, err := github.FetchPRsFromOrg(ctx, org, since, token, nil)
+	prs, err := client.FetchPRsFromOrg(ctx, org, since, token, nil)
 	if err != nil {
 		return fmt.Errorf("failed to fetch PRs: %w", err)
 	}
@@ -208,7 +214,7 @@ func analyzeOrganization(ctx context.Context, org string, sampleSize, days int,
 	totalAuthors := github.CountUniqueAuthors(prs)
 
 	// Count open PRs across the entire organization with a single query
-	totalOpenPRs, err := github.CountOpenPRsInOrg(ctx, org, token)
+	totalOpenPRs, err := client.CountOpenPRsInOrg(ctx, org, token)
 	if err != nil {
 		slog.Warn("Failed to count open PRs in organization, using 0", "error", err)
 		totalOpenPRs = 0

go.mod

@@ -1,13 +1,16 @@
 module github.com/codeGROOVE-dev/prcost
 
-go 1.25.3
+go 1.25.4
 
 require (
-	github.com/codeGROOVE-dev/ds9 v0.6.0
+	github.com/codeGROOVE-dev/ds9 v0.7.1
 	github.com/codeGROOVE-dev/gsm v0.0.0-20251019065141-833fe2363d22
 	github.com/codeGROOVE-dev/prx v0.0.0-20251030022101-ff906928a1e4
 	github.com/codeGROOVE-dev/turnclient v0.0.0-20251030022425-bc3b14acf75e
 	golang.org/x/time v0.14.0
 )
 
-require github.com/codeGROOVE-dev/retry v1.3.0 // indirect
+require (
+	github.com/codeGROOVE-dev/bdcache v0.5.0 // indirect
+	github.com/codeGROOVE-dev/retry v1.3.0 // indirect
+)

go.sum

@@ -1,5 +1,9 @@
+github.com/codeGROOVE-dev/bdcache v0.5.0 h1:62Ns4QOdZ239LtytJDcO+kI4OOr+5SPh/ct81rGEEtY=
+github.com/codeGROOVE-dev/bdcache v0.5.0/go.mod h1:vZlNyKt4Zmse37T9wPZX+J3Kc2fjZlcGzXArQh5W4dc=
 github.com/codeGROOVE-dev/ds9 v0.6.0 h1:JG7vBH17UAKaVoeQilrIvA1I0fg3iNbdUMBSDS7ixgI=
 github.com/codeGROOVE-dev/ds9 v0.6.0/go.mod h1:0UDipxF1DADfqM5GtjefgB2u+EXdDgOKmxVvrSGLHoM=
+github.com/codeGROOVE-dev/ds9 v0.7.1 h1:UuffbTksanUPERBkOsiPOe46fkTJlzBOA9jUyfkBxEI=
+github.com/codeGROOVE-dev/ds9 v0.7.1/go.mod h1:0UDipxF1DADfqM5GtjefgB2u+EXdDgOKmxVvrSGLHoM=
 github.com/codeGROOVE-dev/gsm v0.0.0-20251019065141-833fe2363d22 h1:gtN3rOc6YspO646BkcOxBhPjEqKUz+jl175jIqglfDg=
 github.com/codeGROOVE-dev/gsm v0.0.0-20251019065141-833fe2363d22/go.mod h1:KV+w19ubP32PxZPE1hOtlCpTaNpF0Bpb32w5djO8UTg=
 github.com/codeGROOVE-dev/prx v0.0.0-20251030022101-ff906928a1e4 h1:DSuoUwP3oyR4cHrX0cUh9c7CtYjXNIcyCmqpIwHilIU=