-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathformat_test.go
More file actions
733 lines (687 loc) · 19.4 KB
/
format_test.go
File metadata and controls
733 lines (687 loc) · 19.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
package notify
import (
"context"
"testing"
"time"
"github.com/codeGROOVE-dev/prx/pkg/prx"
"github.com/codeGROOVE-dev/slacker/pkg/config"
"github.com/codeGROOVE-dev/turnclient/pkg/turn"
)
// TestPrefixForState tests state-based emoji selection.
func TestPrefixForState(t *testing.T) {
tests := []struct {
state string
expected string
}{
{"newly_published", ":new:"},
{"awaiting_review", ":hourglass:"},
{"tests_broken", ":cockroach:"},
{"tests_running", ":test_tube:"},
{"changes_requested", ":carpentry_saw:"},
{"approved", ":white_check_mark:"},
{"merged", ":rocket:"},
{"closed", ":x:"},
{"unknown_state", ":postal_horn:"},
{"", ":postal_horn:"},
}
for _, tt := range tests {
t.Run(tt.state, func(t *testing.T) {
emoji := PrefixForState(tt.state)
if emoji != tt.expected {
t.Errorf("expected %q for state %q, got %q", tt.expected, tt.state, emoji)
}
})
}
}
// TestPrefixForAction tests action kind string to emoji mapping.
func TestPrefixForAction(t *testing.T) {
tests := []struct {
actionKind string
expected string
}{
{"review", ":hourglass:"},
{"re_review", ":hourglass:"},
{"request_reviewers", ":hourglass:"},
{"merge", ":rocket:"},
{"approve", ":white_check_mark:"},
{"fix_tests", ":cockroach:"},
{"tests_pending", ":test_tube:"},
{"publish_draft", ":construction:"},
{"resolve_comments", ":carpentry_saw:"},
{"respond", ":carpentry_saw:"},
{"review_discussion", ":carpentry_saw:"},
{"unknown_action", ":postal_horn:"},
}
for _, tt := range tests {
t.Run(tt.actionKind, func(t *testing.T) {
emoji := PrefixForAction(tt.actionKind)
if emoji != tt.expected {
t.Errorf("expected %q for action %q, got %q", tt.expected, tt.actionKind, emoji)
}
})
}
}
// TestFormatNextActionsSuffix tests the suffix formatting for empty cases.
func TestFormatNextActionsSuffix(t *testing.T) {
ctx := context.Background()
// Test with nil CheckResult
params := MessageParams{
CheckResult: nil,
}
suffix := FormatNextActionsSuffix(ctx, params)
if suffix != "" {
t.Errorf("expected empty suffix for nil CheckResult, got %q", suffix)
}
// Test with empty NextAction map
params.CheckResult = &turn.CheckResponse{
Analysis: turn.Analysis{
NextAction: map[string]turn.Action{},
},
}
suffix = FormatNextActionsSuffix(ctx, params)
if suffix != "" {
t.Errorf("expected empty suffix for empty NextAction, got %q", suffix)
}
}
// TestStateParam tests the URL state parameter generation.
func TestStateParam(t *testing.T) {
tests := []struct {
name string
response *turn.CheckResponse
expected string
}{
{
name: "draft PR",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: true},
Analysis: turn.Analysis{},
},
expected: "?st=tests_running",
},
{
name: "failing checks",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Checks: turn.Checks{Failing: 2}},
},
expected: "?st=tests_broken",
},
{
name: "pending checks",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Checks: turn.Checks{Pending: 1}},
},
expected: "?st=tests_running",
},
{
name: "waiting checks",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Checks: turn.Checks{Waiting: 1}},
},
expected: "?st=tests_running",
},
{
name: "approved with unresolved comments",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Approved: true, UnresolvedComments: 3},
},
expected: "?st=changes_requested",
},
{
name: "approved without unresolved comments",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Approved: true, UnresolvedComments: 0},
},
expected: "?st=approved",
},
{
name: "awaiting review",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Approved: false},
},
expected: "?st=awaiting_review",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := stateParam(tt.response)
if result != tt.expected {
t.Errorf("expected %q, got %q", tt.expected, result)
}
})
}
}
// TestFallbackEmoji tests emoji selection when no workflow_state or next_actions.
func TestFallbackEmoji(t *testing.T) {
tests := []struct {
name string
response *turn.CheckResponse
expectedEmoji string
expectedState string
}{
{
name: "draft PR",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: true},
Analysis: turn.Analysis{},
},
expectedEmoji: ":test_tube:",
expectedState: "?st=tests_running",
},
{
name: "failing checks",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Checks: turn.Checks{Failing: 1}},
},
expectedEmoji: ":cockroach:",
expectedState: "?st=tests_broken",
},
{
name: "pending checks",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Checks: turn.Checks{Pending: 2}},
},
expectedEmoji: ":test_tube:",
expectedState: "?st=tests_running",
},
{
name: "waiting checks",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Checks: turn.Checks{Waiting: 1}},
},
expectedEmoji: ":test_tube:",
expectedState: "?st=tests_running",
},
{
name: "approved with unresolved comments",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Approved: true, UnresolvedComments: 2},
},
expectedEmoji: ":carpentry_saw:",
expectedState: "?st=changes_requested",
},
{
name: "approved",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{Approved: true},
},
expectedEmoji: ":white_check_mark:",
expectedState: "?st=approved",
},
{
name: "awaiting review",
response: &turn.CheckResponse{
PullRequest: prx.PullRequest{Draft: false},
Analysis: turn.Analysis{},
},
expectedEmoji: ":hourglass:",
expectedState: "?st=awaiting_review",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
emoji, state := fallbackEmoji(tt.response)
if emoji != tt.expectedEmoji {
t.Errorf("expected emoji %q, got %q", tt.expectedEmoji, emoji)
}
if state != tt.expectedState {
t.Errorf("expected state %q, got %q", tt.expectedState, state)
}
})
}
}
// mockUserMapper for testing formatNextActionsInternal
type mockUserMapper struct{}
func (m *mockUserMapper) FormatUserMentions(ctx context.Context, githubUsers []string, owner, domain string) string {
if len(githubUsers) == 0 {
return ""
}
// Simple mock: just return comma-separated github usernames
result := ""
for i, user := range githubUsers {
if i > 0 {
result += ", "
}
result += "@" + user
}
return result
}
// TestFormatNextActionsInternal tests the internal next actions formatter.
func TestFormatNextActionsInternal(t *testing.T) {
ctx := context.Background()
mapper := &mockUserMapper{}
tests := []struct {
name string
nextActions map[string]turn.Action
expected string
}{
{
name: "empty actions",
nextActions: map[string]turn.Action{},
expected: "",
},
{
name: "single action with user",
nextActions: map[string]turn.Action{
"user1": {Kind: turn.ActionReview},
},
expected: "review: @user1",
},
{
name: "multiple users same action",
nextActions: map[string]turn.Action{
"user1": {Kind: turn.ActionReview},
"user2": {Kind: turn.ActionReview},
},
expected: "review: @user1, @user2",
},
{
name: "system user filtered out",
nextActions: map[string]turn.Action{
"_system": {Kind: turn.ActionReview},
},
expected: "review",
},
{
name: "system and real user",
nextActions: map[string]turn.Action{
"_system": {Kind: turn.ActionReview},
"user1": {Kind: turn.ActionReview},
},
expected: "review: @user1",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := formatNextActionsInternal(ctx, tt.nextActions, "owner", "example.com", mapper)
if result != tt.expected {
t.Errorf("expected %q, got %q", tt.expected, result)
}
})
}
}
// TestFormatChannelMessageBase tests the base channel message formatting.
func TestFormatChannelMessageBase(t *testing.T) {
ctx := context.Background()
tests := []struct {
name string
params MessageParams
contains []string // Substrings that should be in the result
}{
{
name: "merged PR",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{
Merged: true,
MergedAt: timePtr(time.Now()),
},
Analysis: turn.Analysis{},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 42,
Title: "Test PR",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/42",
},
contains: []string{":rocket:", "Test PR", "test-repo#42", "testuser", "?st=merged"},
},
{
name: "closed but not merged",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{
State: "closed",
Merged: false,
},
Analysis: turn.Analysis{},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 43,
Title: "Closed PR",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/43",
},
contains: []string{":x:", "Closed PR", "test-repo#43", "testuser", "?st=closed"},
},
{
name: "newly published",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{},
Analysis: turn.Analysis{
WorkflowState: string(turn.StateNewlyPublished),
},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 44,
Title: "New PR",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/44",
},
contains: []string{":new:", "New PR", "test-repo#44", "testuser", "?st=newly_published"},
},
{
name: "IN_DRAFT",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{},
Analysis: turn.Analysis{
WorkflowState: string(turn.StateInDraft),
},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 45,
Title: "Draft PR",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/45",
},
contains: []string{":construction:", "Draft PR", "test-repo#45", "testuser", "?st=draft"},
},
{
name: "PUBLISHED_WAITING_FOR_TESTS with broken tests",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{},
Analysis: turn.Analysis{
WorkflowState: string(turn.StatePublishedWaitingForTests),
NextAction: map[string]turn.Action{
"author": {Kind: turn.ActionFixTests},
},
},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 46,
Title: "PR with broken tests",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/46",
},
contains: []string{":cockroach:", "PR with broken tests", "test-repo#46", "testuser", "?st=tests_broken"},
},
{
name: "PUBLISHED_WAITING_FOR_TESTS with pending tests",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{},
Analysis: turn.Analysis{
WorkflowState: string(turn.StatePublishedWaitingForTests),
NextAction: map[string]turn.Action{
"author": {Kind: turn.ActionTestsPending},
},
},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 47,
Title: "PR with tests running",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/47",
},
contains: []string{":test_tube:", "PR with tests running", "test-repo#47", "testuser", "?st=tests_running"},
},
{
name: "TESTED_WAITING_FOR_ASSIGNMENT",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{},
Analysis: turn.Analysis{
WorkflowState: string(turn.StateTestedWaitingForAssignment),
},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 48,
Title: "PR needs reviewer assignment",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/48",
},
contains: []string{":shrug:", "PR needs reviewer assignment", "test-repo#48", "testuser", "?st=awaiting_assignment"},
},
{
name: "ASSIGNED_WAITING_FOR_REVIEW",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{},
Analysis: turn.Analysis{
WorkflowState: string(turn.StateAssignedWaitingForReview),
},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 49,
Title: "PR awaiting review",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/49",
},
contains: []string{":hourglass:", "PR awaiting review", "test-repo#49", "testuser", "?st=awaiting_review"},
},
{
name: "REVIEWED_NEEDS_REFINEMENT",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{},
Analysis: turn.Analysis{
WorkflowState: string(turn.StateReviewedNeedsRefinement),
},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 50,
Title: "PR needs changes",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/50",
},
contains: []string{":carpentry_saw:", "PR needs changes", "test-repo#50", "testuser", "?st=changes_requested"},
},
{
name: "REFINED_WAITING_FOR_APPROVAL",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{},
Analysis: turn.Analysis{
WorkflowState: string(turn.StateRefinedWaitingForApproval),
},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 51,
Title: "PR awaiting approval",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/51",
},
contains: []string{":hourglass:", "PR awaiting approval", "test-repo#51", "testuser", "?st=awaiting_approval"},
},
{
name: "APPROVED_WAITING_FOR_MERGE",
params: MessageParams{
CheckResult: &turn.CheckResponse{
PullRequest: prx.PullRequest{},
Analysis: turn.Analysis{
WorkflowState: string(turn.StateApprovedWaitingForMerge),
},
},
Owner: "test-owner",
Repo: "test-repo",
PRNumber: 52,
Title: "PR approved and ready",
Author: "testuser",
HTMLURL: "https://github.com/test-owner/test-repo/pull/52",
},
contains: []string{":white_check_mark:", "PR approved and ready", "test-repo#52", "testuser", "?st=approved"},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := FormatChannelMessageBase(ctx, tt.params)
for _, substr := range tt.contains {
if !contains(result, substr) {
t.Errorf("expected result to contain %q, got: %q", substr, result)
}
}
})
}
}
// contains checks if a string contains a substring.
func contains(s, substr string) bool {
return len(s) >= len(substr) && indexOf(s, substr) >= 0
}
// indexOf returns the index of substr in s, or -1 if not found.
func indexOf(s, substr string) int {
for i := 0; i <= len(s)-len(substr); i++ {
if s[i:i+len(substr)] == substr {
return i
}
}
return -1
}
// timePtr returns a pointer to a time.Time value.
func timePtr(t time.Time) *time.Time {
return &t
}
// TestNew tests the Manager constructor.
func TestNew(t *testing.T) {
// Create a simple mock config manager
mockConfig := &mockConfigManager{}
// Call New - it should not panic
manager := New(nil, mockConfig)
if manager == nil {
t.Fatal("expected non-nil manager")
}
if manager.Tracker == nil {
t.Error("expected Tracker to be initialized")
}
if manager.configManager == nil {
t.Error("expected configManager to be set")
}
}
// TestNewDailyDigestScheduler tests the DailyDigestScheduler constructor.
func TestNewDailyDigestScheduler(t *testing.T) {
mockConfig := &mockConfigManager{}
mockState := &mockStateProvider{}
mockSlack := &mockSlackManager{}
manager := New(nil, mockConfig)
scheduler := NewDailyDigestScheduler(manager, nil, mockConfig, mockState, mockSlack)
if scheduler == nil {
t.Fatal("expected non-nil scheduler")
}
if scheduler.notifier != manager {
t.Error("expected notifier to be set")
}
if scheduler.configManager == nil {
t.Error("expected configManager to be set")
}
if scheduler.stateStore == nil {
t.Error("expected stateStore to be set")
}
if scheduler.slackManager == nil {
t.Error("expected slackManager to be set")
}
}
// mockSlackManager implements SlackManager for testing.
type mockSlackManager struct{}
func (m *mockSlackManager) Client(ctx context.Context, teamID string) (SlackClient, error) {
return nil, nil
}
// mockConfigManager implements the config interface needed by New and ConfigProvider.
type mockConfigManager struct{}
func (m *mockConfigManager) DailyRemindersEnabled(org string) bool {
return true
}
func (m *mockConfigManager) ReminderDMDelay(org, channel string) int {
return 65
}
func (m *mockConfigManager) Domain(org string) string {
return "example.com"
}
func (m *mockConfigManager) Config(org string) (*config.RepoConfig, bool) {
return nil, false
}
// TestFormatNextActionsSuffixWithActions tests suffix with actual user actions.
func TestFormatNextActionsSuffixWithActions(t *testing.T) {
ctx := context.Background()
mapper := &mockUserMapper{}
tests := []struct {
name string
params MessageParams
expected string
}{
{
name: "suffix with review action",
params: MessageParams{
CheckResult: &turn.CheckResponse{
Analysis: turn.Analysis{
NextAction: map[string]turn.Action{
"user1": {Kind: turn.ActionReview},
},
},
},
Owner: "test-owner",
Domain: "example.com",
UserMapper: mapper,
},
expected: " → review: @user1",
},
{
name: "suffix with multiple users",
params: MessageParams{
CheckResult: &turn.CheckResponse{
Analysis: turn.Analysis{
NextAction: map[string]turn.Action{
"user1": {Kind: turn.ActionReview},
"user2": {Kind: turn.ActionReview},
},
},
},
Owner: "test-owner",
Domain: "example.com",
UserMapper: mapper,
},
expected: " → review: ",
},
{
name: "suffix filters system user",
params: MessageParams{
CheckResult: &turn.CheckResponse{
Analysis: turn.Analysis{
NextAction: map[string]turn.Action{
"_system": {Kind: turn.ActionReview},
},
},
},
Owner: "test-owner",
Domain: "example.com",
UserMapper: mapper,
},
expected: " → review",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := FormatNextActionsSuffix(ctx, tt.params)
// For tests with multiple users, just check that result starts with the prefix
// since map iteration order is not guaranteed
if tt.name == "suffix with multiple users" {
if !contains(result, " → review: ") {
t.Errorf("expected result to contain \" → review: \", got: %q", result)
}
} else if result != tt.expected {
t.Errorf("expected %q, got %q", tt.expected, result)
}
})
}
}