-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathfetcher_test.go
More file actions
441 lines (386 loc) · 12 KB
/
fetcher_test.go
File metadata and controls
441 lines (386 loc) · 12 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
package home
import (
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"net/url"
"testing"
"time"
"github.com/codeGROOVE-dev/slacker/pkg/state"
"github.com/google/go-github/v50/github"
)
// TestNewFetcher verifies constructor initializes all fields.
func TestNewFetcher(t *testing.T) {
client := &github.Client{}
token := "test-token"
botUsername := "test-bot"
fetcher := NewFetcher(client, nil, token, botUsername)
if fetcher == nil {
t.Fatal("expected non-nil fetcher")
}
if fetcher.githubClient != client {
t.Error("expected githubClient to be set")
}
if fetcher.githubToken != token {
t.Error("expected githubToken to be set")
}
if fetcher.botUsername != botUsername {
t.Error("expected botUsername to be set")
}
}
// TestSortPRs verifies PR sorting logic (blocked first, then by recency).
func TestSortPRs(t *testing.T) {
now := time.Now()
tests := []struct {
name string
prs []PR
expected []int // Expected PR numbers in sorted order
}{
{
name: "blocked PRs come first",
prs: []PR{
{Number: 1, UpdatedAt: now.Add(-1 * time.Hour), IsBlocked: false},
{Number: 2, UpdatedAt: now.Add(-2 * time.Hour), IsBlocked: true},
{Number: 3, UpdatedAt: now.Add(-30 * time.Minute), IsBlocked: false},
},
expected: []int{2, 3, 1}, // Blocked first (2), then by recency (3, 1)
},
{
name: "needs review treated as blocked",
prs: []PR{
{Number: 1, UpdatedAt: now.Add(-1 * time.Hour), IsBlocked: false, NeedsReview: false},
{Number: 2, UpdatedAt: now.Add(-2 * time.Hour), IsBlocked: false, NeedsReview: true},
{Number: 3, UpdatedAt: now.Add(-30 * time.Minute), IsBlocked: false, NeedsReview: false},
},
expected: []int{2, 3, 1}, // NeedsReview first (2), then by recency (3, 1)
},
{
name: "sort by recency when all same blocking status",
prs: []PR{
{Number: 1, UpdatedAt: now.Add(-5 * time.Hour), IsBlocked: false},
{Number: 2, UpdatedAt: now.Add(-1 * time.Hour), IsBlocked: false},
{Number: 3, UpdatedAt: now.Add(-3 * time.Hour), IsBlocked: false},
},
expected: []int{2, 3, 1}, // Most recent first
},
{
name: "multiple blocked - sort by recency",
prs: []PR{
{Number: 1, UpdatedAt: now.Add(-1 * time.Hour), IsBlocked: true},
{Number: 2, UpdatedAt: now.Add(-3 * time.Hour), IsBlocked: true},
{Number: 3, UpdatedAt: now.Add(-2 * time.Hour), IsBlocked: true},
},
expected: []int{1, 3, 2}, // All blocked, so by recency
},
{
name: "empty list",
prs: []PR{},
expected: []int{},
},
{
name: "single PR",
prs: []PR{
{Number: 42, UpdatedAt: now, IsBlocked: false},
},
expected: []int{42},
},
{
name: "mixed blocked and needs review",
prs: []PR{
{Number: 1, UpdatedAt: now.Add(-1 * time.Hour), IsBlocked: true, NeedsReview: false},
{Number: 2, UpdatedAt: now.Add(-2 * time.Hour), IsBlocked: false, NeedsReview: true},
{Number: 3, UpdatedAt: now.Add(-30 * time.Minute), IsBlocked: false, NeedsReview: false},
},
expected: []int{1, 2, 3}, // Both blocked/needs review first by recency, then non-blocked by recency
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
sortPRs(tt.prs)
if len(tt.prs) != len(tt.expected) {
t.Fatalf("length mismatch: got %d, want %d", len(tt.prs), len(tt.expected))
}
for i, expectedNum := range tt.expected {
if tt.prs[i].Number != expectedNum {
t.Errorf("position %d: got PR#%d, want PR#%d", i, tt.prs[i].Number, expectedNum)
}
}
})
}
}
// TestFetchUserPRs_InputValidation tests input validation for username and org names.
func TestFetchUserPRs_InputValidation(t *testing.T) {
f := &Fetcher{
githubClient: &github.Client{},
stateStore: nil,
}
ctx := context.Background()
tests := []struct {
name string
username string
workspaceOrgs []string
expectEmpty bool
}{
{
name: "empty username returns empty",
username: "",
workspaceOrgs: []string{"test-org"},
expectEmpty: true,
},
{
name: "username with space returns empty",
username: "user name",
workspaceOrgs: []string{"test-org"},
expectEmpty: true,
},
{
name: "username with tab returns empty",
username: "user\tname",
workspaceOrgs: []string{"test-org"},
expectEmpty: true,
},
{
name: "username with newline returns empty",
username: "user\nname",
workspaceOrgs: []string{"test-org"},
expectEmpty: true,
},
{
name: "username with quote returns empty",
username: "user\"name",
workspaceOrgs: []string{"test-org"},
expectEmpty: true,
},
{
name: "org with space is skipped",
username: "validuser",
workspaceOrgs: []string{"invalid org"},
expectEmpty: true,
},
{
name: "empty org list returns empty",
username: "validuser",
workspaceOrgs: []string{},
expectEmpty: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
incoming, outgoing := f.fetchUserPRs(ctx, tt.username, tt.workspaceOrgs)
if !tt.expectEmpty {
t.Skip("test expects non-empty, but would require GitHub API mocking")
}
if len(incoming) != 0 {
t.Errorf("expected empty incoming PRs, got %d", len(incoming))
}
if len(outgoing) != 0 {
t.Errorf("expected empty outgoing PRs, got %d", len(outgoing))
}
})
}
}
// mockStateStore implements state.Store interface for testing.
type mockStateStore struct {
threads map[string]state.ThreadInfo
}
func (m *mockStateStore) Thread(owner, repo string, number int, channelID string) (state.ThreadInfo, bool) {
key := owner + "/" + repo + "/" + string(rune(number))
info, exists := m.threads[key]
return info, exists
}
func (m *mockStateStore) SaveThread(owner, repo string, number int, channelID string, info state.ThreadInfo) error {
return nil
}
func (m *mockStateStore) LastDM(userID, prURL string) (time.Time, bool) {
return time.Time{}, false
}
func (m *mockStateStore) RecordDM(userID, prURL string, sentAt time.Time) error {
return nil
}
func (m *mockStateStore) DMMessage(userID, prURL string) (state.DMInfo, bool) {
return state.DMInfo{}, false
}
func (m *mockStateStore) SaveDMMessage(userID, prURL string, info state.DMInfo) error {
return nil
}
func (m *mockStateStore) ListDMUsers(prURL string) []string {
return nil
}
func (m *mockStateStore) LastDigest(userID, date string) (time.Time, bool) {
return time.Time{}, false
}
func (m *mockStateStore) RecordDigest(userID, date string, sentAt time.Time) error {
return nil
}
func (m *mockStateStore) WasProcessed(eventKey string) bool {
return false
}
func (m *mockStateStore) MarkProcessed(eventKey string, ttl time.Duration) error {
return nil
}
func (m *mockStateStore) LastNotification(prURL string) time.Time {
return time.Time{}
}
func (m *mockStateStore) RecordNotification(prURL string, notifiedAt time.Time) error {
return nil
}
func (m *mockStateStore) Cleanup() error {
return nil
}
func (m *mockStateStore) QueuePendingDM(dm state.PendingDM) error {
return nil
}
func (m *mockStateStore) GetPendingDMs(before time.Time) ([]state.PendingDM, error) {
return nil, nil
}
func (m *mockStateStore) RemovePendingDM(id string) error {
return nil
}
func (m *mockStateStore) Close() error {
return nil
}
// TestSearchPRs tests GitHub search API integration.
func TestSearchPRs(t *testing.T) {
// Create mock GitHub API server
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.URL.Path == "/search/issues" {
// Return mock search results
response := github.IssuesSearchResult{
Total: github.Int(1),
Issues: []*github.Issue{
{
Number: github.Int(123),
Title: github.String("Test PR"),
HTMLURL: github.String("https://github.com/test-org/test-repo/pull/123"),
RepositoryURL: github.String("https://api.github.com/repos/test-org/test-repo"),
User: &github.User{
Login: github.String("testuser"),
},
UpdatedAt: &github.Timestamp{Time: time.Now().Add(-1 * time.Hour)},
PullRequestLinks: &github.PullRequestLinks{
URL: github.String("https://api.github.com/repos/test-org/test-repo/pulls/123"),
},
},
},
}
w.Header().Set("Content-Type", "application/json")
json.NewEncoder(w).Encode(response)
return
}
http.NotFound(w, r)
}))
defer server.Close()
client := github.NewClient(nil)
client.BaseURL = mustParseURL(server.URL + "/")
mockStore := &mockStateStore{
threads: map[string]state.ThreadInfo{
"test-org/test-repo/\x7b": { // \x7b is ASCII for '{'
LastEventTime: time.Now().Add(-30 * time.Minute),
},
},
}
f := &Fetcher{
githubClient: client,
stateStore: mockStore,
}
ctx := context.Background()
prs, err := f.searchPRs(ctx, "is:pr is:open author:testuser org:test-org")
if err != nil {
t.Fatalf("searchPRs failed: %v", err)
}
if len(prs) != 1 {
t.Fatalf("expected 1 PR, got %d", len(prs))
}
if prs[0].Number != 123 {
t.Errorf("expected PR #123, got #%d", prs[0].Number)
}
if prs[0].Repository != "test-org/test-repo" {
t.Errorf("expected repo test-org/test-repo, got %s", prs[0].Repository)
}
}
func mustParseURL(s string) *url.URL {
u, err := url.Parse(s)
if err != nil {
panic(err)
}
return u
}
// TestFetchDashboard tests the main dashboard fetching logic.
func TestFetchDashboard(t *testing.T) {
// Create mock GitHub API server
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.URL.Path == "/search/issues" {
query := r.URL.Query().Get("q")
var issues []*github.Issue
if containsStr(query, "author:testuser") {
// Outgoing PRs
issues = []*github.Issue{
{
Number: github.Int(456),
Title: github.String("My PR"),
HTMLURL: github.String("https://github.com/org/repo/pull/456"),
RepositoryURL: github.String("https://api.github.com/repos/org/repo"),
User: &github.User{Login: github.String("testuser")},
UpdatedAt: &github.Timestamp{Time: time.Now().Add(-2 * time.Hour)},
PullRequestLinks: &github.PullRequestLinks{
URL: github.String("https://api.github.com/repos/org/repo/pulls/456"),
},
},
}
} else if containsStr(query, "review-requested:testuser") {
// Incoming PRs
issues = []*github.Issue{
{
Number: github.Int(789),
Title: github.String("Review needed"),
HTMLURL: github.String("https://github.com/org/repo/pull/789"),
RepositoryURL: github.String("https://api.github.com/repos/org/repo"),
User: &github.User{Login: github.String("otheruser")},
UpdatedAt: &github.Timestamp{Time: time.Now().Add(-1 * time.Hour)},
PullRequestLinks: &github.PullRequestLinks{
URL: github.String("https://api.github.com/repos/org/repo/pulls/789"),
},
},
}
}
response := github.IssuesSearchResult{
Total: github.Int(len(issues)),
Issues: issues,
}
w.Header().Set("Content-Type", "application/json")
json.NewEncoder(w).Encode(response)
return
}
http.NotFound(w, r)
}))
defer server.Close()
client := github.NewClient(nil)
client.BaseURL = mustParseURL(server.URL + "/")
f := NewFetcher(client, &mockStateStore{threads: make(map[string]state.ThreadInfo)}, "", "bot")
ctx := context.Background()
dashboard, err := f.FetchDashboard(ctx, "testuser", []string{"org"})
if err != nil {
t.Fatalf("FetchDashboard failed: %v", err)
}
if len(dashboard.IncomingPRs) != 1 {
t.Errorf("expected 1 incoming PR, got %d", len(dashboard.IncomingPRs))
}
if len(dashboard.OutgoingPRs) != 1 {
t.Errorf("expected 1 outgoing PR, got %d", len(dashboard.OutgoingPRs))
}
if len(dashboard.WorkspaceOrgs) != 1 || dashboard.WorkspaceOrgs[0] != "org" {
t.Errorf("expected workspace orgs [org], got %v", dashboard.WorkspaceOrgs)
}
}
func containsStr(s, substr string) bool {
return len(s) >= len(substr) && indexOfStr(s, substr) >= 0
}
func indexOfStr(s, substr string) int {
for i := 0; i <= len(s)-len(substr); i++ {
if s[i:i+len(substr)] == substr {
return i
}
}
return -1
}