Merge pull request #90 from tstromberg/reliable

increase test coverage

Author: tstromberg

pkg/bot/bot_test.go

@@ -512,6 +512,110 @@ func TestShouldPostThread(t *testing.T) {
 			wantPost:       true,
 			wantReasonPart: "invalid_config",
 		},
+		{
+			name: "passing: posts when in StateReviewedNeedsRefinement",
+			when: "passing",
+			checkResult: &turn.CheckResponse{
+				PullRequest: prx.PullRequest{
+					State: "open",
+				},
+				Analysis: turn.Analysis{
+					WorkflowState: string(turn.StateReviewedNeedsRefinement),
+				},
+			},
+			wantPost:       true,
+			wantReasonPart: "workflow_state",
+		},
+		{
+			name: "passing: posts when in StateRefinedWaitingForApproval",
+			when: "passing",
+			checkResult: &turn.CheckResponse{
+				PullRequest: prx.PullRequest{
+					State: "open",
+				},
+				Analysis: turn.Analysis{
+					WorkflowState: string(turn.StateRefinedWaitingForApproval),
+				},
+			},
+			wantPost:       true,
+			wantReasonPart: "workflow_state",
+		},
+		{
+			name: "passing: posts when in StateApprovedWaitingForMerge",
+			when: "passing",
+			checkResult: &turn.CheckResponse{
+				PullRequest: prx.PullRequest{
+					State: "open",
+				},
+				Analysis: turn.Analysis{
+					WorkflowState: string(turn.StateApprovedWaitingForMerge),
+				},
+			},
+			wantPost:       true,
+			wantReasonPart: "workflow_state",
+		},
+		{
+			name: "passing: does not post when StateNewlyPublished",
+			when: "passing",
+			checkResult: &turn.CheckResponse{
+				PullRequest: prx.PullRequest{
+					State: "open",
+				},
+				Analysis: turn.Analysis{
+					WorkflowState: string(turn.StateNewlyPublished),
+				},
+			},
+			wantPost:       false,
+			wantReasonPart: "waiting_for",
+		},
+		{
+			name: "passing: does not post when StateInDraft",
+			when: "passing",
+			checkResult: &turn.CheckResponse{
+				PullRequest: prx.PullRequest{
+					State: "open",
+				},
+				Analysis: turn.Analysis{
+					WorkflowState: string(turn.StateInDraft),
+				},
+			},
+			wantPost:       false,
+			wantReasonPart: "waiting_for",
+		},
+		{
+			name: "passing: does not post when StateTestedWaitingForAssignment",
+			when: "passing",
+			checkResult: &turn.CheckResponse{
+				PullRequest: prx.PullRequest{
+					State: "open",
+				},
+				Analysis: turn.Analysis{
+					WorkflowState: string(turn.StateTestedWaitingForAssignment),
+				},
+			},
+			wantPost:       false,
+			wantReasonPart: "waiting_for",
+		},
+		{
+			name: "passing: uses fallback when tests have Waiting status",
+			when: "passing",
+			checkResult: &turn.CheckResponse{
+				PullRequest: prx.PullRequest{
+					State: "open",
+				},
+				Analysis: turn.Analysis{
+					WorkflowState: "unknown_state",
+					Checks: turn.Checks{
+						Passing: 0,
+						Failing: 0,
+						Pending: 0,
+						Waiting: 3,
+					},
+				},
+			},
+			wantPost:       false,
+			wantReasonPart: "tests_pending",
+		},
 	}
 
 	for _, tt := range tests {

pkg/bot/coordinator_test_helpers.go

@@ -18,17 +18,20 @@ import (
 //
 //nolint:govet // fieldalignment optimization would reduce test readability
 type mockStateStore struct {
-	markProcessedErr  error
-	saveThreadErr     error
-	saveDMMessageErr  error
-	threads           map[string]cache.ThreadInfo
-	dmTimes           map[string]time.Time
-	dmUsers           map[string][]string
-	dmMessages        map[string]state.DMInfo
-	pendingDMs        []*state.PendingDM
-	processedEvents   map[string]bool
-	lastNotifications map[string]time.Time
-	mu                sync.Mutex
+	markProcessedErr   error
+	saveThreadErr      error
+	saveDMMessageErr   error
+	queuePendingDMErr  error
+	pendingDMsErr      error
+	removePendingDMErr error
+	threads            map[string]cache.ThreadInfo
+	dmTimes            map[string]time.Time
+	dmUsers            map[string][]string
+	dmMessages         map[string]state.DMInfo
+	pendingDMs         []*state.PendingDM
+	processedEvents    map[string]bool
+	lastNotifications  map[string]time.Time
+	mu                 sync.Mutex
 }
 
 func (m *mockStateStore) Thread(ctx context.Context, owner, repo string, number int, channelID string) (cache.ThreadInfo, bool) {
@@ -180,13 +183,19 @@ func (m *mockStateStore) RecordNotification(ctx context.Context, prURL string, n
 func (m *mockStateStore) QueuePendingDM(ctx context.Context, dm *state.PendingDM) error {
 	m.mu.Lock()
 	defer m.mu.Unlock()
+	if m.queuePendingDMErr != nil {
+		return m.queuePendingDMErr
+	}
 	m.pendingDMs = append(m.pendingDMs, dm)
 	return nil
 }
 
 func (m *mockStateStore) PendingDMs(ctx context.Context, before time.Time) ([]state.PendingDM, error) {
 	m.mu.Lock()
 	defer m.mu.Unlock()
+	if m.pendingDMsErr != nil {
+		return nil, m.pendingDMsErr
+	}
 	var result []state.PendingDM
 	for _, dm := range m.pendingDMs {
 		if dm.SendAfter.Before(before) {
@@ -199,6 +208,9 @@ func (m *mockStateStore) PendingDMs(ctx context.Context, before time.Time) ([]st
 func (m *mockStateStore) RemovePendingDM(ctx context.Context, id string) error {
 	m.mu.Lock()
 	defer m.mu.Unlock()
+	if m.removePendingDMErr != nil {
+		return m.removePendingDMErr
+	}
 	for i, dm := range m.pendingDMs {
 		if dm.ID == id {
 			m.pendingDMs = append(m.pendingDMs[:i], m.pendingDMs[i+1:]...)