Skip to content

Commit 437f800

Browse files
committed
[St] Updates excluded tests and expected failures in SMTP suite, implements quit placeholder
1 parent 6d0ce9d commit 437f800

1 file changed

Lines changed: 21 additions & 5 deletions

File tree

rosetta-test-s/RosettaS-Suites/RosettaSMTPSuite.class.st

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,9 @@ RosettaSMTPSuite >> excludeCapabilities [
3232
'root.commands.expn'
3333
'root.crlf-injection-detection.commands.detection.expn'
3434
'root.smtputf8'
35-
'root.8bitmime.send-message.mandatory-options'
35+
'root.8bitmime.send-message.explicit-options'
3636
37-
38-
"decided to detect"
37+
"SMTPClient detects CRLF injection"
3938
'root.crlf-injection-detection.commands.mitigation'
4039
'root.crlf-injection-detection.send-message.mitigation'
4140
@@ -49,7 +48,13 @@ RosettaSMTPSuite >> excludeTests [
4948

5049
^ #('test_other_auth_failures'
5150
'test_buggy_auth_with_too_many_challenges' "AUTH method not supported"
52-
'test_Timeout_during_connect_to_server_with_TLS')
51+
52+
"SqueakSSL does not work"
53+
'test_Timeout_during_connect_to_server_with_TLS'
54+
'test_Connect_to_server_with_TLS'
55+
56+
"We do not check types in these situations"
57+
'test_Connect_with_non-numeric_port_is_an_error')
5358
]
5459

5560
{ #category : #private }
@@ -195,7 +200,7 @@ RosettaSMTPSuite >> smtpExtensions: smtp ehloResponse: response env: env [
195200

196201
<rosettaPlaceholderName: 'smtp-extensions'>
197202

198-
^ smtp serverCapabilities
203+
^ smtp serverCapabilities keys
199204
]
200205

201206
{ #category : #'suite definition' }
@@ -224,6 +229,17 @@ RosettaSMTPSuite >> smtpMail: smtp from: fromAddress mailOptions: options env: e
224229
^ self getResponse: smtp
225230
]
226231

232+
{ #category : #'suite definition' }
233+
RosettaSMTPSuite >> smtpQuit: client env: env [
234+
235+
<rosettaPlaceholderName: 'smtp-quit'>
236+
237+
[client quit]
238+
on: ProtocolClientError
239+
do: [:e | ^ e].
240+
^ self getResponse: client
241+
]
242+
227243
{ #category : #'suite definition' }
228244
RosettaSMTPSuite >> smtpRcpt: smtp to: recipientAddresses options: optionLists env: env [
229245

0 commit comments

Comments
 (0)