Skip to content

Commit 6d0ce9d

Browse files
committed
[St] Slight improvements to RosettaSuite and Placeholder classes
1 parent 752dead commit 6d0ce9d

2 files changed

Lines changed: 2 additions & 15 deletions

File tree

rosetta-test-s/RosettaS-Core/RosettaSuite.class.st

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ RosettaSuite >> createPlaceholder: aConsCell [
9494
at: newPlaceholder placeholderName asSymbol
9595
put: newPlaceholder.
9696

97-
9897
newPlaceholder
9998
function: (placeholderFunctions at: aConsCell first ifAbsent: nil).
10099

@@ -156,7 +155,7 @@ RosettaSuite >> gatherBridgeFunctions [
156155
placeholderMethods := placeholderMethods groupBy: [:m |
157156
m pragmas
158157
detect: [:p | p keyword = #rosettaPlaceholderName:]
159-
ifFound: [:p | p argumentAt: 1]
158+
ifFound: [:p | (p argumentAt: 1) asSymbol]
160159
ifNone: [self error]].
161160
(placeholderMethods select: [:group | group size > 1]) keysAndValuesDo: [:placeholderName :methods |
162161
Notification signal: 'Duplicate placeholder method for: ' , placeholderName].
@@ -248,18 +247,6 @@ RosettaSuite >> rosettaLibrarySource [
248247
rosettaFile contents]
249248
]
250249

251-
{ #category : #running }
252-
RosettaSuite >> rosettaRun [
253-
254-
"self assert: self suite notNil.
255-
self
256-
fillPlaceholders;
257-
installPlaceholders.
258-
259-
self allTests do: [:rosettaTest |
260-
self rosettaRunTest: rosettaTest]."
261-
]
262-
263250
{ #category : #running }
264251
RosettaSuite >> rosettaRunTest: aRosettaTest [
265252

rosetta-test-s/RosettaS-Interpreter/RosettaPlaceholder.class.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,6 @@ RosettaPlaceholder >> printOn: aStream [
7575
{ #category : #evaluating }
7676
RosettaPlaceholder >> value: values [
7777

78-
self assert: self function notNil.
78+
self assert: self function notNil description: 'Function ' , placeholderName , 'is not defined.'.
7979
^ self function valueWithArguments: values , {self env}
8080
]

0 commit comments

Comments
 (0)