fix: compliance test suite fixes

Author: codeadict

README.md

@@ -11,24 +11,15 @@ HTTP/1.1 and HTTP/2 support. Pure Erlang. Zero dependencies.
 
 ## Why?
 
-- **Fast**: Optimized for performance with inline compilation and buffer tuning
-- **Simple**: Small API surface, easy to understand
-- **Correct**: Proper HTTP/1.1 and HTTP/2 protocol handling
-- **Flexible**: Works with both protocols transparently
+Fast. Small API. Proper HTTP/1.1 and HTTP/2 support. Works with both protocols transparently.
 
 Built to replace `httpc` with better performance and cleaner code.
 
 ## HTTP/2 Compliance
 
-**156 compliance tests** covering RFC 7540 (HTTP/2) and RFC 7541 (HPACK)
+**156 tests** covering RFC 7540 (HTTP/2) and RFC 7541 (HPACK). All frame types, stream states, flow control, priority handling, HPACK compression, and error conditions.
 
-- Complete frame type validation (DATA, HEADERS, SETTINGS, PING, etc.)
-- Stream state machine verification
-- Flow control and priority handling
-- HPACK compression/decompression
-- All error conditions tested
-
-Tested against [h2-client-test-harness](https://github.com/nomadlabsinc/h2-client-test-harness) with **100% pass rate**.
+Tested against [h2-client-test-harness](https://github.com/nomadlabsinc/h2-client-test-harness). **100% pass rate**.
 
 ## Quick Start
 

include/gen_http.hrl

@@ -10,6 +10,6 @@
     | {headers, request_ref(), headers()}
     | {data, request_ref(), binary()}
     | {done, request_ref()}.
--type socket() :: term().
+-type socket() :: gen_tcp:socket() | ssl:sslsocket().
 
 -define(DEFAULT_PROTOCOLS, [http1, http2]).

src/gen_http.erl

@@ -2,8 +2,7 @@
 
 %% @doc Unified interface for HTTP/1.1 and HTTP/2 connections.
 %%
-%% This module provides protocol-agnostic functions that work with both
-%% gen_http_h1 and gen_http_h2 connections.
+%% Protocol-agnostic functions that work with both gen_http_h1 and gen_http_h2.
 
 %% Compiler optimizations for hot-path functions
 -compile(inline).
@@ -370,7 +369,7 @@ get_socket(Conn) when is_tuple(Conn) ->
 
 %% @doc Store a private key-value pair in the connection.
 %%
-%% This allows users to attach metadata to connections (e.g., pool ID, metrics, tags).
+%% Attach metadata to connections (e.g., pool ID, metrics, tags).
 %% Works with both HTTP/1.1 and HTTP/2 connections.
 %%
 %% ## Examples

src/gen_http_h1.erl

@@ -3,13 +3,13 @@
 
 %% @doc HTTP/1.1 connection state machine.
 %%
-%% This module implements a process-less HTTP/1.1 client with support for:
+%% Process-less HTTP/1.1 client. Supports:
 %% - Request pipelining
 %% - Keep-alive connections
 %% - Chunked transfer encoding
 %% - Body streaming (request and response)
 %%
-%% The connection state is a pure data structure passed between function calls.
+%% Connection state is a pure data structure passed between function calls.
 
 %% Compiler optimizations for hot-path functions
 -compile(inline).
@@ -310,7 +310,7 @@ get_socket(#gen_http_h1_conn{socket = Socket}) ->
 
 %% @doc Store a private key-value pair in the connection.
 %%
-%% This allows users to attach metadata to connections (e.g., pool ID, metrics, tags).
+%% Attach metadata to connections (e.g., pool ID, metrics, tags).
 -spec put_private(conn(), Key :: term(), Value :: term()) -> conn().
 put_private(#gen_http_h1_conn{private = Private} = Conn, Key, Value) ->
     Conn#gen_http_h1_conn{private = maps:put(Key, Value, Private)}.

src/gen_http_h2.erl

@@ -3,15 +3,15 @@
 
 %% @doc HTTP/2 connection state machine.
 %%
-%% This module implements a process-less HTTP/2 client with support for:
+%% Process-less HTTP/2 client. Supports:
 %% - Stream multiplexing (multiple concurrent requests)
 %% - Flow control (connection and stream level)
 %% - Settings negotiation
 %% - HPACK header compression
 %% - Server push
 %% - GOAWAY handling
 %%
-%% The connection state is a pure data structure passed between function calls.
+%% Connection state is a pure data structure passed between function calls.
 
 %% Compiler optimizations for hot-path functions
 -compile(inline).
@@ -367,7 +367,7 @@ get_socket(#gen_http_h2_conn{socket = Socket}) ->
 
 %% @doc Store a private key-value pair in the connection.
 %%
-%% This allows users to attach metadata to connections (e.g., pool ID, metrics, tags).
+%% Attach metadata to connections (e.g., pool ID, metrics, tags).
 -spec put_private(conn(), Key :: term(), Value :: term()) -> conn().
 put_private(#gen_http_h2_conn{private = Private} = Conn, Key, Value) ->
     Conn#gen_http_h2_conn{private = maps:put(Key, Value, Private)}.

src/gen_http_parser_hpack.erl

@@ -2,11 +2,11 @@
 
 %% @doc HPACK: Header Compression for HTTP/2 (RFC 7541).
 %%
-%% This module implements HPACK header compression with static and dynamic tables.
-%% The compression context is pure data (no process state).
+%% HPACK header compression with static and dynamic tables.
+%% Compression context is pure data (no process state).
 %%
-%% Huffman encoding is enabled by default and automatically used when it
-%% reduces the string size (typically ~30% compression for header values).
+%% Huffman encoding is used when it reduces string size
+%% (typically ~30% compression for header values).
 
 -export([
     new/0,

test/README.md

@@ -4,12 +4,7 @@ This directory contains tests for the gen_http HTTP client library.
 
 ## Test Infrastructure
 
-Tests use a local Docker-based infrastructure instead of making requests to external websites. This provides:
-
-- **Reliability**: Tests don't fail due to network issues
-- **Speed**: Local requests are much faster
-- **Control**: We control the test server behavior
-- **Privacy**: No external requests during development
+Tests run against local Docker containers instead of hitting external websites. This means tests won't randomly fail from network issues, they run faster, and you're not leaking requests during development.
 
 ### Test Server Setup
 
@@ -65,19 +60,19 @@ docker compose -f test/support/docker-compose.yml down -v
 
 ## Test Server Endpoints
 
-The local httpbin service provides the following endpoints:
+httpbin gives you these endpoints:
 
 - `GET /get` - Returns GET request data
 - `POST /post` - Returns POST request data
 - `GET /status/{code}` - Returns specified HTTP status code
 - `GET /delay/{seconds}` - Delays response
 - `GET /redirect/{n}` - 302 redirect n times
 - `POST /anything` - Returns anything sent
-- And many more (see [httpbin.org](https://httpbin.org/) for full API)
+- Plus more at [httpbin.org](https://httpbin.org/)
 
 ## Configuration
 
-Test server ports can be configured via environment variables:
+Change ports with environment variables:
 
 - `HTTPBIN_HTTP_PORT` (default: 8080) - HTTP server port
 - `HTTPBIN_HTTPS_PORT` (default: 8443) - HTTPS server port
@@ -101,15 +96,11 @@ If tests are being skipped with "Test server not available", ensure:
 
 ### Port conflicts
 
-If ports 8080 or 8443 are already in use:
-
-1. Stop conflicting services
-2. Or change ports in `.env` file
-3. Restart Docker Compose
+If ports 8080 or 8443 are already in use, either stop whatever's using them or change the ports in `.env` and restart docker compose.
 
 ### SSL certificate errors
 
-The Caddy server uses self-signed certificates for local testing. Tests should use the `verify_none` SSL option:
+Caddy uses self-signed certificates for local testing. Use `verify_none` in your tests:
 
 ```erlang
 {ok, Conn} = gen_http:connect(https, "localhost", 8443, #{