Add interactive multi-select skill install

Author: codeaholicguy

docs/ai/design/feature-skill-add-interactive-selection.md

@@ -18,7 +18,7 @@ graph TD
   SkillManager --> CacheResolver[cloneRepositoryToCache]
   CacheResolver --> RegistryRepo[registry checkout/cache]
   RegistryRepo --> SkillEnumerator[scan skills/*/SKILL.md]
-  SkillEnumerator --> Prompt[inquirer list prompt]
+  SkillEnumerator --> Prompt[inquirer checkbox prompt]
   Prompt --> SkillManager
   SkillManager --> Installer[existing addSkill install path]
   Installer --> ConfigManager[project config update]
@@ -35,13 +35,11 @@ graph TD
 interface RegistrySkillChoice {
   name: string;
   description?: string;
-  skillPath: string;
 }
 
 interface AddSkillOptions {
   global?: boolean;
   environments?: string[];
-  interactive?: boolean;
 }
 ```
 
@@ -64,13 +62,13 @@ interface AddSkillOptions {
 ```ts
 async addSkill(registryId: string, skillName?: string, options?: AddSkillOptions): Promise<void>;
 async listRegistrySkills(registryId: string): Promise<RegistrySkillChoice[]>;
-async promptForSkillSelection(skills: RegistrySkillChoice[]): Promise<string>;
+async promptForSkillSelection(skills: RegistrySkillChoice[]): Promise<string[]>;
 ```
 
 **Behavior contract:**
 
 - If `skillName` is provided, skip prompting.
-- If `skillName` is missing and `stdout`/`stdin` are interactive, enumerate skills and prompt.
+- If `skillName` is missing and `stdout`/`stdin` are interactive, enumerate skills and prompt for one or more selections.
 - If `skillName` is missing in a non-interactive context, fail with an error instructing the user to provide `<skill-name>`.
 - If the prompt is cancelled, exit without side effects.
 - If exactly one valid skill exists and `skillName` is omitted, still show the selector instead of auto-installing.
@@ -88,6 +86,7 @@ async promptForSkillSelection(skills: RegistrySkillChoice[]): Promise<string>;
      - existing installation logic
    - Add a helper that enumerates valid skills from the cloned registry.
    - Add a helper that prompts with `inquirer`.
+   - Reuse the existing install path for each selected skill.
 3. `packages/cli/src/__tests__/commands/skill.test.ts`
    - Add command-level coverage for omitted skill name.
 4. `packages/cli/src/__tests__/lib/SkillManager.test.ts`
@@ -103,6 +102,9 @@ async promptForSkillSelection(skills: RegistrySkillChoice[]): Promise<string>;
 - Keep interactive selection explicit even for single-skill registries:
   - It matches the stated UX requirement.
   - It avoids hidden behavior changes between one-skill and multi-skill registries.
+- Allow multi-select installation in the prompt:
+  - It reduces repetitive command invocations when a user wants several skills from the same registry.
+  - It keeps the explicit two-argument command unchanged for scripted single-skill installs.
 - Prefer cached registry contents when refresh fails:
   - It keeps the command usable offline or during transient network failures.
   - It aligns with existing cache-oriented registry behavior.
@@ -132,3 +134,4 @@ async promptForSkillSelection(skills: RegistrySkillChoice[]): Promise<string>;
   - Continue validating `registryId` and selected `skillName` before installation.
 - Usability:
   - Prompt entries should display skill name and short description when available.
+  - Users should be able to select multiple skills in one prompt.

docs/ai/planning/feature-skill-add-interactive-selection.md

@@ -10,27 +10,27 @@ feature: skill-add-interactive-selection
 ## Milestones
 **What are the major checkpoints?**
 
-- [ ] Milestone 1: Command contract updated to allow omitted skill name without breaking explicit installs.
-- [ ] Milestone 2: `SkillManager` can enumerate registry skills and prompt for one interactively.
-- [ ] Milestone 3: Tests cover prompt and non-prompt flows, plus failure cases.
+- [x] Milestone 1: Command contract updated to allow omitted skill name without breaking explicit installs.
+- [x] Milestone 2: `SkillManager` can enumerate registry skills and prompt for one interactively.
+- [x] Milestone 3: Tests cover prompt and non-prompt flows, plus failure cases.
 
 ## Task Breakdown
 **What specific work needs to be done?**
 
 ### Phase 1: Command Surface
-- [ ] Task 1.1: Update `packages/cli/src/commands/skill.ts` so `add` accepts `[skill-name]`.
-- [ ] Task 1.2: Update command descriptions/help text to document the interactive shorthand.
+- [x] Task 1.1: Update `packages/cli/src/commands/skill.ts` so `add` accepts `[skill-name]`.
+- [x] Task 1.2: Update command descriptions/help text to document the interactive shorthand.
 
 ### Phase 2: Interactive Selection Flow
-- [ ] Task 2.1: Refactor `SkillManager.addSkill` so it can resolve a missing skill name before install.
-- [ ] Task 2.2: Implement registry skill enumeration from the cloned/cached repository.
-- [ ] Task 2.3: Implement an `inquirer` selection prompt with skill name and short description labels.
-- [ ] Task 2.4: Handle cancel, empty registry, invalid registry, and non-interactive contexts cleanly.
+- [x] Task 2.1: Refactor `SkillManager.addSkill` so it can resolve a missing skill name before install.
+- [x] Task 2.2: Implement registry skill enumeration from the cloned/cached repository.
+- [x] Task 2.3: Implement an `inquirer` selection prompt with skill name and short description labels.
+- [x] Task 2.4: Handle cancel, empty registry, invalid registry, and non-interactive contexts cleanly.
 
 ### Phase 3: Validation & Regression Coverage
-- [ ] Task 3.1: Add `SkillManager` unit tests for enumeration and prompt behavior.
-- [ ] Task 3.2: Add command-level tests for `ai-devkit skill add <registry>` and explicit two-arg installs.
-- [ ] Task 3.3: Verify no regression in config updates and environment resolution after interactive selection.
+- [x] Task 3.1: Add `SkillManager` unit tests for enumeration and prompt behavior.
+- [x] Task 3.2: Add command-level tests for `ai-devkit skill add <registry>` and explicit two-arg installs.
+- [x] Task 3.3: Verify no regression in config updates and environment resolution after interactive selection.
 
 ## Dependencies
 **What needs to happen in what order?**
@@ -49,10 +49,10 @@ graph TD
 ## Timeline & Estimates
 **When will things be done?**
 
-- Phase 1: 0.25 day
-- Phase 2: 0.5 day
-- Phase 3: 0.5 day
-- Total estimated effort: 1.25 days
+- Phase 1: completed
+- Phase 2: completed
+- Phase 3: completed
+- Total implementation effort: completed within the current session
 
 ## Risks & Mitigation
 **What could go wrong?**
@@ -70,3 +70,6 @@ graph TD
 - Existing `inquirer` dependency already used across the CLI.
 - Existing `SkillManager` cache and registry resolution helpers.
 - Jest command/lib test suites for regression coverage.
+
+## Progress Summary
+Implementation is complete for the current scope. The `skill add` command now accepts an omitted skill name, `SkillManager` resolves available skills from the target registry checkout with cached fallback on refresh failure, and targeted Jest coverage verifies direct install, interactive multi-selection, cancellation, non-interactive failure, and cache-backed selection behavior. Remaining lifecycle work should move to implementation review rather than additional Phase 4 coding unless new scope is introduced.

docs/ai/requirements/feature-skill-add-interactive-selection.md

@@ -32,7 +32,7 @@ feature: skill-add-interactive-selection
 
 - Allow `ai-devkit skill add <registry>` to enter an interactive selection flow when `<skill-name>` is omitted.
 - Build the selectable list from the requested registry itself, not from a hardcoded list.
-- Reuse the existing installation path once the user selects a skill.
+- Reuse the existing installation path once the user selects one or more skills.
 - Keep the existing explicit flow `ai-devkit skill add <registry> <skill-name>` unchanged.
 
 **Secondary goals:**
@@ -43,16 +43,15 @@ feature: skill-add-interactive-selection
 
 **Non-goals (explicitly out of scope):**
 
-- Multi-select installation in one command.
 - Fuzzy search across all registries in the add flow.
 - Changing `skill find` behavior.
 - Adding a new registry metadata format.
 
 ## User Stories & Use Cases
 **How will users interact with the solution?**
 
-1. As a developer, I want to run `ai-devkit skill add my-org/skills` so I can choose a skill interactively when I do not remember the exact skill name.
-2. As a developer, I want the CLI to show the actual skills available in that registry so I can install one without opening GitHub.
+1. As a developer, I want to run `ai-devkit skill add my-org/skills` so I can choose one or more skills interactively when I do not remember the exact skill names.
+2. As a developer, I want the CLI to show the actual skills available in that registry so I can install several of them without opening GitHub.
 3. As an automation user, I want `ai-devkit skill add <registry> <skill-name>` to keep working non-interactively so existing scripts do not break.
 
 **Key workflows and scenarios:**
@@ -61,8 +60,8 @@ feature: skill-add-interactive-selection
   - CLI validates the registry.
   - CLI fetches or reuses the cached registry repository.
   - CLI extracts available skills from `skills/*/SKILL.md`.
-  - CLI shows an interactive selection list, even if the registry only exposes one valid skill.
-  - CLI installs the selected skill using the existing add flow.
+  - CLI shows an interactive multi-selection list, even if the registry only exposes one valid skill.
+  - CLI installs each selected skill using the existing add flow.
 - User runs `ai-devkit skill add <registry> <skill-name>`:
   - Existing direct install flow continues with no interactive prompt.
 - User cancels the prompt:
@@ -84,7 +83,7 @@ feature: skill-add-interactive-selection
 - `ai-devkit skill add <registry>` is accepted by the CLI.
 - When run interactively, the command displays a selection list populated from the target registry.
 - The command still shows the selection list when the registry contains exactly one valid skill.
-- Selecting a skill installs it through the existing installation path and updates project config exactly as today.
+- Selecting one or more skills installs each of them through the existing installation path and updates project config exactly as today.
 - `ai-devkit skill add <registry> <skill-name>` continues to work without prompting.
 - Invalid, empty, and non-interactive cases return actionable error messages.
 - If registry refresh fails but a cached copy exists, the command warns and uses the cached list.
@@ -109,4 +108,4 @@ feature: skill-add-interactive-selection
 ## Questions & Open Items
 **What do we still need to clarify?**
 
-- None for Phase 2 review. The prompt uses a single-select list whenever `<skill-name>` is omitted, and cached registry content is acceptable when refresh fails.
+- None for Phase 2 review. The prompt uses a multi-select list whenever `<skill-name>` is omitted, and cached registry content is acceptable when refresh fails.

docs/ai/testing/feature-skill-add-interactive-selection.md

@@ -18,51 +18,63 @@ feature: skill-add-interactive-selection
 **What individual components need testing?**
 
 ### SkillManager
-- [ ] Test case 1: Omitting `skillName` triggers registry enumeration and prompt selection.
-- [ ] Test case 2: Providing `skillName` skips the prompt entirely.
-- [ ] Test case 3: Invalid registry throws before prompt.
-- [ ] Test case 4: Empty registry throws a clear error.
-- [ ] Test case 5: Non-interactive mode without `skillName` throws a clear error.
-- [ ] Test case 6: Prompt cancellation exits without config writes or installs.
+- [x] Test case 1: Omitting `skillName` triggers registry enumeration and prompt selection.
+- [x] Test case 2: Providing `skillName` skips the prompt entirely.
+- [x] Test case 3: Invalid registry throws before prompt.
+- [x] Test case 4: Empty registry throws a clear error.
+- [x] Test case 5: Non-interactive mode without `skillName` throws a clear error.
+- [x] Test case 6: Prompt cancellation exits without config writes or installs.
+- [x] Test case 7: Multi-selection installs more than one skill in a single run.
+- [x] Test case 8: Cached registry contents are used when refresh fails.
+- [x] Test case 9: Global installation still works after interactive multi-selection.
 
 ### Skill Command
-- [ ] Test case 1: `skill add <registry>` is parsed successfully.
-- [ ] Test case 2: `skill add <registry> <skill-name>` still forwards both args correctly.
-- [ ] Test case 3: Help text reflects the interactive shorthand.
+- [x] Test case 1: `skill add <registry>` is parsed successfully.
+- [x] Test case 2: `skill add <registry> <skill-name>` still forwards both args correctly.
+- [x] Test case 3: Cancellation is surfaced as a warning instead of an error exit.
+- [x] Test case 4: Command shape reflects the optional `[skill-name]` argument.
 
 ## Integration Tests
 **How do we test component interactions?**
 
-- [ ] Registry cache is prepared before enumeration.
-- [ ] Selected skill flows into the existing install path and config update.
-- [ ] Global install options still work after interactive selection.
+- [x] Registry cache is prepared before enumeration.
+- [x] Selected skill flows into the existing install path and config update.
+- [x] Global install options still work after interactive selection.
 
 ## End-to-End Tests
 **What user flows need validation?**
 
-- [ ] User flow 1: Install a skill from a registry by selecting from the prompt.
-- [ ] User flow 2: Install a known skill directly with two arguments.
-- [ ] User flow 3: Cancel out of the prompt with no side effects.
+- [x] User flow 1: Install skill(s) from a registry by selecting from the prompt.
+- [x] User flow 2: Install a known skill directly with two arguments.
+- [x] User flow 3: Cancel out of the prompt with no side effects.
 
 ## Test Data
 **What data do we use for testing?**
 
 - Mock registry repositories with valid `skills/<name>/SKILL.md` folders.
 - One malformed skill directory fixture to verify skip behavior.
 - Mocked prompt responses for selection and cancellation.
+- TTY stubs for interactive vs non-interactive command behavior.
 
 ## Test Reporting & Coverage
 **How do we verify and communicate test results?**
 
 - Run focused Jest suites for `commands/skill` and `lib/SkillManager`.
 - Confirm changed branches include prompt, no-prompt, and error paths.
+- Latest verification evidence:
+  - `npm test -- skill.test.ts`
+  - `npm test -- SkillManager.test.ts`
+  - `npx ai-devkit@latest lint --feature skill-add-interactive-selection`
+- Remaining coverage gap:
+  - no command-level assertion for full rendered help output text; current coverage checks the registered argument shape instead
 
 ## Manual Testing
 **What requires human validation?**
 
 - Prompt readability when many skills are present.
 - Cancellation UX in a real terminal session.
 - Global vs project install messaging after selection.
+- Checkbox prompt usability when only one skill is available.
 
 ## Performance Testing
 **How do we validate performance?**

packages/cli/src/__tests__/commands/skill.test.ts

@@ -0,0 +1,89 @@
+import { Command } from 'commander';
+import { beforeEach, describe, expect, it, jest } from '@jest/globals';
+import { registerSkillCommand } from '../../commands/skill';
+import { ui } from '../../util/terminal-ui';
+
+const mockAddSkill = jest.fn();
+
+jest.mock('../../lib/Config', () => ({
+  ConfigManager: jest.fn(),
+}));
+
+jest.mock('../../lib/SkillManager', () => ({
+  SkillManager: jest.fn(() => ({
+    addSkill: (...args: unknown[]) => mockAddSkill(...args),
+    listSkills: jest.fn(),
+    removeSkill: jest.fn(),
+    updateSkills: jest.fn(),
+    findSkills: jest.fn(),
+    rebuildIndex: jest.fn(),
+  })),
+}));
+
+jest.mock('../../util/terminal-ui', () => ({
+  ui: {
+    error: jest.fn(),
+    warning: jest.fn(),
+    info: jest.fn(),
+    text: jest.fn(),
+    table: jest.fn(),
+  },
+}));
+
+describe('skill command', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+    mockAddSkill.mockImplementation(async () => undefined);
+    jest.spyOn(process, 'exit').mockImplementation((() => undefined) as any);
+  });
+
+  it('parses skill add with registry only and forwards undefined skill name', async () => {
+    const program = new Command();
+    registerSkillCommand(program);
+
+    await program.parseAsync(['node', 'test', 'skill', 'add', 'anthropics/skills']);
+
+    expect(mockAddSkill).toHaveBeenCalledWith('anthropics/skills', undefined, {
+      global: undefined,
+      environments: undefined,
+    });
+  });
+
+  it('parses skill add with explicit skill name and forwards both args', async () => {
+    const program = new Command();
+    registerSkillCommand(program);
+
+    await program.parseAsync(['node', 'test', 'skill', 'add', 'anthropics/skills', 'frontend-design']);
+
+    expect(mockAddSkill).toHaveBeenCalledWith('anthropics/skills', 'frontend-design', {
+      global: undefined,
+      environments: undefined,
+    });
+  });
+
+  it('shows a warning instead of exiting when skill selection is cancelled', async () => {
+    mockAddSkill.mockImplementation(async () => {
+      throw new Error('Skill selection cancelled.');
+    });
+
+    const program = new Command();
+    registerSkillCommand(program);
+
+    await program.parseAsync(['node', 'test', 'skill', 'add', 'anthropics/skills']);
+
+    expect(ui.warning).toHaveBeenCalledWith('Skill selection cancelled.');
+    expect(ui.error).not.toHaveBeenCalled();
+    expect(process.exit).not.toHaveBeenCalled();
+  });
+
+  it('registers the add command with an optional skill-name argument', () => {
+    const program = new Command();
+    registerSkillCommand(program);
+
+    const skillCommand = program.commands.find(command => command.name() === 'skill');
+    const addCommand = skillCommand?.commands.find(command => command.name() === 'add');
+
+    expect(addCommand?.usage()).toContain('<registry-repo>');
+    expect(addCommand?.usage()).toContain('[skill-name]');
+  });
+});