refactor(agent-manager): replace hardcoded types with enums

Author: codeaholicguy

docs/ai/design/feature-agent-manager.md

@@ -72,7 +72,8 @@ Types are adapted for a data-first package contract:
 - **AgentInfo**: Full agent information (name, type, status, pid, projectPath, sessionId, slug, lastActive, etc.)
 - **ProcessInfo**: `{ pid, command, cwd, tty }`
 - **AgentAdapter**: Interface with `type`, `detectAgents()`, `canHandle()`
-- **TerminalLocation**: `{ type, identifier, tty }` (from TerminalFocusManager)
+- **TerminalType**: Enum (`TMUX`, `ITERM2`, `TERMINAL_APP`, `UNKNOWN`)
+- **TerminalLocation**: `{ type: TerminalType, identifier, tty }` (from TerminalFocusManager)
 
 ## API Design
 
@@ -89,7 +90,7 @@ export { AgentStatus } from './adapters/AgentAdapter';
 export type { AgentType, AgentInfo, ProcessInfo } from './adapters/AgentAdapter';
 
 // Terminal
-export { TerminalFocusManager } from './terminal/TerminalFocusManager';
+export { TerminalFocusManager, TerminalType } from './terminal/TerminalFocusManager';
 export type { TerminalLocation } from './terminal/TerminalFocusManager';
 
 // Utilities

docs/ai/implementation/feature-agent-manager.md

@@ -103,6 +103,9 @@ Data-model refinements (February 25, 2026):
   - Removed `AgentInfo.statusDisplay`
   - Removed `AgentInfo.lastActiveDisplay`
 - Updated `ClaudeCodeAdapter` to return data-only fields (`status`, `lastActive`, `summary`) without UI formatting
+- Replaced hardcoded string literals with enums where appropriate:
+  - Added `TerminalType` enum for terminal location/focus flow
+  - Added `SessionEntryType` enum in `ClaudeCodeAdapter` status logic
 
 ## Phase 6 Check Implementation (February 25, 2026)
 

packages/agent-manager/src/adapters/ClaudeCodeAdapter.ts

@@ -19,11 +19,21 @@ interface SessionsIndex {
     originalPath: string;
 }
 
+enum SessionEntryType {
+    ASSISTANT = 'assistant',
+    USER = 'user',
+    PROGRESS = 'progress',
+    THINKING = 'thinking',
+    SYSTEM = 'system',
+    MESSAGE = 'message',
+    TEXT = 'text',
+}
+
 /**
  * Entry in session JSONL file
  */
 interface SessionEntry {
-    type?: 'assistant' | 'user' | 'progress' | 'thinking' | 'system' | 'message' | 'text';
+    type?: SessionEntryType;
     timestamp?: string;
     slug?: string;
     cwd?: string;
@@ -289,24 +299,24 @@ export class ClaudeCodeAdapter implements AgentAdapter {
             return AgentStatus.IDLE;
         }
 
-        if (entryType === 'user') {
+        if (entryType === SessionEntryType.USER) {
             // Check if user interrupted manually - this puts agent back in waiting state
             const content = session.lastEntry.message?.content;
             if (Array.isArray(content)) {
                 const isInterrupted = content.some(c =>
-                    (c.type === 'text' && c.text?.includes('[Request interrupted')) ||
+                    (c.type === SessionEntryType.TEXT && c.text?.includes('[Request interrupted')) ||
                     (c.type === 'tool_result' && c.content?.includes('[Request interrupted'))
                 );
                 if (isInterrupted) return AgentStatus.WAITING;
             }
             return AgentStatus.RUNNING;
         }
 
-        if (entryType === 'progress' || entryType === 'thinking') {
+        if (entryType === SessionEntryType.PROGRESS || entryType === SessionEntryType.THINKING) {
             return AgentStatus.RUNNING;
-        } else if (entryType === 'assistant') {
+        } else if (entryType === SessionEntryType.ASSISTANT) {
             return AgentStatus.WAITING;
-        } else if (entryType === 'system') {
+        } else if (entryType === SessionEntryType.SYSTEM) {
             return AgentStatus.IDLE;
         }
 

packages/agent-manager/src/index.ts

@@ -4,7 +4,7 @@ export { ClaudeCodeAdapter } from './adapters/ClaudeCodeAdapter';
 export { AgentStatus } from './adapters/AgentAdapter';
 export type { AgentAdapter, AgentType, AgentInfo, ProcessInfo } from './adapters/AgentAdapter';
 
-export { TerminalFocusManager } from './terminal/TerminalFocusManager';
+export { TerminalFocusManager, TerminalType } from './terminal/TerminalFocusManager';
 export type { TerminalLocation } from './terminal/TerminalFocusManager';
 
 export { listProcesses, getProcessCwd, getProcessTty, isProcessRunning, getProcessInfo } from './utils/process';

packages/agent-manager/src/terminal/TerminalFocusManager.ts

@@ -5,8 +5,15 @@ import { getProcessTty } from '../utils/process';
 const execAsync = promisify(exec);
 const execFileAsync = promisify(execFile);
 
+export enum TerminalType {
+    TMUX = 'tmux',
+    ITERM2 = 'iterm2',
+    TERMINAL_APP = 'terminal-app',
+    UNKNOWN = 'unknown',
+}
+
 export interface TerminalLocation {
-    type: 'tmux' | 'iterm2' | 'terminal-app' | 'unknown';
+    type: TerminalType;
     identifier: string; // e.g., "session:window.pane" for tmux, or TTY for others
     tty: string;        // e.g., "/dev/ttys030"
 }
@@ -39,7 +46,7 @@ export class TerminalFocusManager {
 
         // 4. Fallback: we know the TTY but not the emulator wrapper
         return {
-            type: 'unknown',
+            type: TerminalType.UNKNOWN,
             identifier: '',
             tty: fullTty
         };
@@ -51,11 +58,11 @@ export class TerminalFocusManager {
     async focusTerminal(location: TerminalLocation): Promise<boolean> {
         try {
             switch (location.type) {
-                case 'tmux':
+                case TerminalType.TMUX:
                     return await this.focusTmuxPane(location.identifier);
-                case 'iterm2':
+                case TerminalType.ITERM2:
                     return await this.focusITerm2Session(location.tty);
-                case 'terminal-app':
+                case TerminalType.TERMINAL_APP:
                     return await this.focusTerminalAppWindow(location.tty);
                 default:
                     return false;
@@ -78,7 +85,7 @@ export class TerminalFocusManager {
                 const [paneTty, identifier] = line.split('|');
                 if (paneTty === tty && identifier) {
                     return {
-                        type: 'tmux',
+                        type: TerminalType.TMUX,
                         identifier,
                         tty
                     };
@@ -113,7 +120,7 @@ export class TerminalFocusManager {
             const { stdout } = await execAsync(`osascript -e '${script}'`);
             if (stdout.trim() === "found") {
                 return {
-                    type: 'iterm2',
+                    type: TerminalType.ITERM2,
                     identifier: tty,
                     tty
                 };
@@ -145,7 +152,7 @@ export class TerminalFocusManager {
             const { stdout } = await execAsync(`osascript -e '${script}'`);
             if (stdout.trim() === "found") {
                 return {
-                    type: 'terminal-app',
+                    type: TerminalType.TERMINAL_APP,
                     identifier: tty,
                     tty
                 };

packages/agent-manager/src/terminal/index.ts

@@ -1,2 +1,3 @@
 export { TerminalFocusManager } from './TerminalFocusManager';
+export { TerminalType } from './TerminalFocusManager';
 export type { TerminalLocation } from './TerminalFocusManager';