fix: no environments defined when running skill add

Author: codeaholicguy

packages/cli/src/__tests__/lib/SkillManager.test.ts

@@ -549,6 +549,7 @@ describe("SkillManager", () => {
     });
 
     it("should create config if missing", async () => {
+      jest.spyOn(skillManager as any, 'isInteractiveTerminal').mockReturnValue(true);
       mockConfigManager.read.mockResolvedValue(null);
       mockConfigManager.create.mockResolvedValue({
         environments: [],
@@ -569,6 +570,7 @@ describe("SkillManager", () => {
     });
 
     it("should select environments when config exists but has no environments", async () => {
+      jest.spyOn(skillManager as any, 'isInteractiveTerminal').mockReturnValue(true);
       mockConfigManager.read.mockResolvedValue({
         environments: [],
       } as any);
@@ -585,6 +587,17 @@ describe("SkillManager", () => {
       });
     });
 
+    it("should throw in non-interactive mode when no environments configured", async () => {
+      jest.spyOn(skillManager as any, 'isInteractiveTerminal').mockReturnValue(false);
+      mockConfigManager.read.mockResolvedValue({
+        environments: [],
+      } as any);
+
+      await expect(
+        skillManager.addSkill(mockRegistryId, mockSkillName),
+      ).rejects.toThrow('No environments configured. Run "ai-devkit init" or add "environments" in .ai-devkit.json.');
+    });
+
     it("should throw error if no skill-capable environments configured", async () => {
       mockConfigManager.read.mockResolvedValue({
         environments: ["windsurf", "gemini"],

packages/cli/src/lib/SkillManager.ts

@@ -131,7 +131,11 @@ export class SkillManager {
       config = await this.configManager.create();
     }
 
-    if (config.environments.length === 0) {
+    if (!config.environments || config.environments.length === 0) {
+      if (!this.isInteractiveTerminal()) {
+        throw new Error('No environments configured. Run "ai-devkit init" or add "environments" in .ai-devkit.json.');
+      }
+
       const selectedEnvs = await this.environmentSelector.selectSkillEnvironments();
       config.environments = selectedEnvs;
       await this.configManager.update({ environments: selectedEnvs });
@@ -175,7 +179,7 @@ export class SkillManager {
     const seenSkills = new Set<string>();
 
     const config = await this.configManager.read();
-    if (!config || config.environments.length === 0) {
+    if (!config || !config.environments || config.environments.length === 0) {
       ui.warning('No .ai-devkit.json found or no environments configured.');
       return [];
     }
@@ -234,7 +238,7 @@ export class SkillManager {
     validateSkillName(skillName);
 
     const config = await this.configManager.read();
-    if (!config || config.environments.length === 0) {
+    if (!config || !config.environments || config.environments.length === 0) {
       throw new Error('No .ai-devkit.json found. Run: ai-devkit init');
     }