Skip to content

Commit 3db193f

Browse files
authored
Merge pull request #2502 from mroderick/fix/events-sponsors-eager-loading
fix: eager load sponsors and sponsorships in EventsController
2 parents bad901a + 94348d0 commit 3db193f

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

app/controllers/events_controller.rb

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,19 @@ class EventsController < ApplicationController
88
def index
99
fresh_when(latest_model_updated, etag: latest_model_updated)
1010

11-
events = [Workshop.past.includes(:chapter).joins(:chapter).merge(Chapter.active).limit(RECENT_EVENTS_DISPLAY_LIMIT)]
11+
events = [Workshop.past.includes(:chapter,
12+
:sponsors).joins(:chapter).merge(Chapter.active).limit(RECENT_EVENTS_DISPLAY_LIMIT)]
1213
events << Meeting.past.includes(:venue).limit(RECENT_EVENTS_DISPLAY_LIMIT)
13-
events << Event.past.includes(:venue, :sponsors).limit(RECENT_EVENTS_DISPLAY_LIMIT)
14+
events << Event.past.includes(:venue, :sponsors, :sponsorships).limit(RECENT_EVENTS_DISPLAY_LIMIT)
1415
events = events.compact.flatten.sort_by(&:date_and_time).reverse.first(RECENT_EVENTS_DISPLAY_LIMIT)
1516
events_hash_grouped_by_date = events.group_by(&:date)
1617
@past_events = events_hash_grouped_by_date.map.each_with_object({}) do |(key, value), hash|
1718
hash[key] = EventPresenter.decorate_collection(value)
1819
end
1920

20-
events = [Workshop.includes(:chapter).upcoming.joins(:chapter).merge(Chapter.active)]
21+
events = [Workshop.includes(:chapter, :sponsors).upcoming.joins(:chapter).merge(Chapter.active)]
2122
events << Meeting.upcoming.all
22-
events << Event.upcoming.includes(:venue, :sponsors).all
23+
events << Event.upcoming.includes(:venue, :sponsors, :sponsorships).all
2324
events = events.compact.flatten.sort_by(&:date_and_time).group_by(&:date)
2425
@events = events.map.each_with_object({}) do |(key, value), hash|
2526
hash[key] = EventPresenter.decorate_collection(value)

0 commit comments

Comments
 (0)