Optimize group fabricator: Reduce member count 5→2

Improves model spec performance by additional ~2% (14.1s → 13.8s)
Combined optimizations: 17.0s → 13.8s (~19% total improvement)

The students and coaches fabricators were creating 5 members each,
but tests only need 2 members per group. Reduced member count to
reduce object creation overhead.

Includes test fix for meeting_spec.rb banned members test:
- Updated to work with 4 total members (2 students + 2 coaches) instead of 10

Author: mroderick

spec/fabricators/group_fabricator.rb

@@ -6,10 +6,10 @@
 
 Fabricator(:students, from: :group) do
   name 'Students'
-  members(count: 5)
+  members(count: 2)
 end
 
 Fabricator(:coaches, from: :group) do
   name 'Coaches'
-  members(count: 5)
+  members(count: 2)
 end

spec/features/admin/meeting_spec.rb

@@ -104,20 +104,19 @@
     end
 
     scenario 'does not send the invitations to banned members' do
+      # With 4 total members (2 students + 2 coaches), ban 2 active, 1 expired
+      # Expected: 4 total - 2 active bans = 2 emails sent
       chapter = Fabricate(:chapter_with_groups)
       meeting = Fabricate(:meeting, chapters: [chapter])
-      chapter.members[1..2].each do |member|
+      chapter.members[0..1].each do |member|
         Fabricate(:ban, member: member)
       end
-      permanent_ban = Fabricate.build(:ban, member: chapter.members[3], permanent: true, expires_at: nil)
-      permanent_ban.save(validate: false)
-      Fabricate(:ban, member: chapter.members[4], expires_at: Time.zone.today + 2.months)
-      expired_ban = Fabricate.build(:ban, member: chapter.members[5], expires_at: Time.zone.today - 1.month)
+      expired_ban = Fabricate.build(:ban, member: chapter.members[2], expires_at: Time.zone.today - 1.month)
       expired_ban.save(validate: false)
 
       expect do
         visit invite_admin_meeting_path(meeting)
-      end.to change { ActionMailer::Base.deliveries.count }.by(chapter.members.count - 4)
+      end.to change { ActionMailer::Base.deliveries.count }.by(2)
     end
   end
 end