Apply test optimizations and fixes from PR #2596

Fixes broken tests due to fabricator changes:
- Update controller and view to use event_student_spaces? and event_coach_spaces?
- Update test files to work with optimized fabricators
- Add UNLOGGED tables rake task for test performance

Full suite: 17.2s → 13.9s (19% improvement)

Author: mroderick

app/controllers/workshop_invitation_controller.rb

@@ -91,8 +91,8 @@ def invitation_params
   end
 
   def available_spaces?(workshop, invitation)
-    (invitation.role.eql?('Student') && workshop.student_spaces?) ||
-      (invitation.role.eql?('Coach') && workshop.coach_spaces?)
+    (invitation.role.eql?('Student') && workshop.event_student_spaces?) ||
+      (invitation.role.eql?('Coach') && workshop.event_coach_spaces?)
   end
 
   # Inline from InvitationControllerConcerns

app/views/workshop_invitation/show.html.haml

@@ -80,7 +80,7 @@
                   = @invitation.member.bans.active.first.reason
             - else
               - if @invitation.for_coach?
-                - if @workshop.coach_spaces?
+                - if @workshop.event_coach_spaces?
                   = link_to 'Keep your skills up-to-date!', edit_member_path
                   %span.d-block
                     %small= I18n.t('workshop_invitation.coach_skills_tooltip')
@@ -91,7 +91,7 @@
                 - else
                   = render partial: 'workshop_invitation/waiting_list', locals: { invitation: @invitation }
               - else
-                - if @workshop.student_spaces?
+                - if @workshop.event_student_spaces?
                   = simple_form_for @invitation, url: :accept_invitation, method: :post do |f|
                     = f.input :tutorial, collection: @tutorial_titles, include_blank: true
                     = f.input :note, required: false, input_html: { rows: 3, maxlength: 100 }, hint: 'Anything else we should know?', placeholder: 'e.g. I need help understanding selectors'

lib/tasks/test_unlogged.rake

@@ -0,0 +1,27 @@
+namespace :db do
+  namespace :test do
+    desc "Convert all tables to UNLOGGED for faster test performance"
+    task unlogged: :environment do
+      raise "This task only works in test environment" unless Rails.env.test?
+
+      tables = ActiveRecord::Base.connection.tables
+      converted = 0
+      tables.each do |table|
+        next if table == "schema_migrations" || table == "ar_internal_metadata"
+        result = ActiveRecord::Base.connection.execute(
+          "SELECT relpersistence FROM pg_class WHERE relname = '#{table}'"
+        )
+        if result.first && result.first["relpersistence"] != "u"
+          ActiveRecord::Base.connection.execute("ALTER TABLE #{table} SET UNLOGGED")
+          converted += 1
+        end
+      end
+      puts "Converted #{converted} tables to UNLOGGED" if converted > 0
+    end
+  end
+end
+
+# Auto-run after db:test:prepare
+Rake::Task["db:test:prepare"].enhance do
+  Rake::Task["db:test:unlogged"].invoke if Rails.env.test?
+end

spec/fabricators/workshop_fabricator.rb

@@ -2,12 +2,14 @@
   date_and_time Time.zone.now + 2.days
   ends_at { |attrs| attrs[:date_and_time] + 2.hours }
   chapter
+  student_spaces { |transients| transients[:student_count] || 10 }
+  coach_spaces { |transients| transients[:coach_count] || 10 }
   after_build do |workshop, transients|
     Fabricate(:workshop_sponsor,
               workshop: workshop,
               sponsor: Fabricate(:sponsor,
                                  seats: transients[:student_count] || 10,
-                                 number_of_coaches: transients[:coach_count || 10]),
+                                 number_of_coaches: transients[:coach_count] || 10),
               host: true)
   end
 

spec/features/accepting_invitation_spec.rb

@@ -5,7 +5,7 @@
     let(:invitation_route) { invitation_path(invitation) }
     let(:accept_invitation_route) { accept_invitation_path(invitation) }
     let(:reject_invitation_route) { reject_invitation_path(invitation) }
-    let(:set_no_available_slots) { invitation.workshop.host.update_attribute(:seats, 0) }
+    let(:set_no_available_slots) { invitation.workshop.update_attribute(:student_spaces, 0) }
     let!(:tutorial) { Fabricate(:tutorial) }
 
     it_behaves_like 'invitation route'

spec/features/admin/chapters_spec.rb

@@ -31,7 +31,7 @@
   end
 
   context '#editing a chapter' do
-    let(:chapter) { Fabricate(:chapter) }
+    let(:chapter) { Fabricate(:chapter_with_organiser) }
 
     context 'organiser editing their chapter' do
       before do
@@ -146,7 +146,7 @@
   end
 
   context 'eligible members tooltip' do
-    let(:chapter) { Fabricate(:chapter_with_groups) }
+    let(:chapter) { Fabricate(:chapter) }
 
     before do
       login_as_admin(member)

spec/features/admin/event_spec.rb

@@ -1,6 +1,6 @@
 RSpec.feature 'Event creation', type: :feature do
   let(:member) { Fabricate(:member) }
-  let(:chapter) { Fabricate(:chapter_with_groups) }
+  let(:chapter) { Fabricate(:chapter) }
 
   describe 'an authorised member' do
     before do

spec/features/admin/filtering_sponsors_list_spec.rb

@@ -6,7 +6,7 @@
   end
 
   describe 'when visiting the sponsors page' do
-    let!(:sponsors) { Fabricate.times(2, :sponsor_with_contacts) }
+    let!(:sponsors) { Fabricate.times(2, :sponsor) }
 
     before(:each) do
       visit admin_sponsors_path

spec/features/admin/manage_event_spec.rb

@@ -1,6 +1,6 @@
 RSpec.feature 'Managing events', type: :feature do
   let(:member) { Fabricate(:member) }
-  let!(:chapter) { Fabricate(:chapter_with_groups) }
+  let!(:chapter) { Fabricate(:chapter) }
   let!(:event) { Fabricate(:event, confirmation_required: true) }
 
   before do

spec/features/admin/managing_organisers_spec.rb

@@ -1,6 +1,6 @@
 RSpec.feature 'Managing organisers', type: :feature do
   let(:member) { Fabricate(:member) }
-  let(:chapter) { Fabricate(:chapter) }
+  let(:chapter) { Fabricate(:chapter_with_organiser) }
 
   scenario 'non admin cannot manage organisers' do
     login(member)