refactor(tests): convert feedback request email tests to delivery assertions

Simplifies after create hook tests by removing mock-based tests
and replacing with direct email delivery verification.

Changes:
- Consolidates two mock-based tests into one email delivery test
- Verifies email is sent and has expected subject

Removes allow().to receive() and have_received() mocks

Author: mroderick

spec/models/feedback_request_spec.rb

@@ -25,18 +25,13 @@
   end
 
   context 'after create hook' do
-    it '#email' do
-      feedback_request = Fabricate.build(:feedback_request)
-      allow(feedback_request).to receive(:email)
-      allow(feedback_request).to receive(:member_id).and_return(:member_id)
-      feedback_request.save
-      expect(feedback_request).to have_received(:email)
-    end
-
     it 'sends request feedback email' do
-      allow(FeedbackRequestMailer).to receive(:request_feedback) { double('feedback_request_mailer').as_null_object }
-      Fabricate(:feedback_request)
-      expect(FeedbackRequestMailer).to have_received(:request_feedback)
+      expect {
+        Fabricate(:feedback_request)
+      }.to change { ActionMailer::Base.deliveries.count }.by(1)
+
+      email = ActionMailer::Base.deliveries.last
+      expect(email.subject).to include('Feedback')
     end
   end
 end