Replace BBC API tutorials for Vonage#474
Merged
KimberleyCook merged 5 commits intogh-pagesfrom May 11, 2021
Merged
Conversation
KimberleyCook
requested review from
brunogirin,
despo,
gnclmorais and
matyikriszta
KimberleyCook
changed the title
KimberleyCook
force-pushed
the
replace-js-api-tutorials-for-vonage
branch
5 times, most recently
from
4e76db9 to
f6c0057
Compare
Contributor
Author
|
@matyikriszta undid the folder restructure so that this PR is easier to review, the new one is called 4a now instead. |
matyikriszta
reviewed
May 7, 2021
matyikriszta
approved these changes
May 7, 2021
Contributor
matyikriszta
left a comment
matyikriszta
left a comment
There was a problem hiding this comment.
@KimberleyCook left one small suggestion but it's not blocking, otherwise good to go 👍
gnclmorais
approved these changes
May 8, 2021
KimberleyCook
force-pushed
the
replace-js-api-tutorials-for-vonage
branch
from
f6c0057 to
d479c33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed the BBC tutorial and replaced it with a link to the Vonage one.
I also gave the rest of the tutorial a little update, updated some terminology, removed the terminal curl requests (I think at this stage they're not needed).