Conversation
Fill in the Practice now ConsoleCrane page: an avatar voice picker (voices fetched from the server), an inline save-first flow, and a Start button that opens the dashboard live-session gate via the login_with_token deep-link. Free users see their remaining AI-session allocation (read from profile) and are prompted to upgrade once used up. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Show "Practice with AI" and "Preview flashcard" in word-detail regardless of login — flashcard preview has no auth guard, and the practice-config page now handles the login prompt itself. In practice-config the voice picker + duration hint are always shown; only the footer changes across states (logged out -> "Log in & save first"; logged in + unsaved -> save-first flow; saved -> Start/Upgrade). The picker stays mounted across saving so the chosen voice is kept. Point the free-tier Upgrade button at the dashboard /settings/subscription page. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Promote the phrase being practiced to a large bold heading (the focal point) and demote "Practice now" to a small eyebrow label, so the phrase is obvious at a glance. Also add tests for the logged-out paths: the login CTA dispatches an OpenLoginWindowMessage, and the isLogin watch advances the page to the save-first flow after login (the voice picker persists across it). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Collaborator
Author
navidshad
changed the title
|
🎉 This PR is included in version 1.12.0-dev.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷️ PR Title:
Enhance Practice Now Feature with Voice Session Config, Improved Login Flows, and Dashboard Deep-Linking
📋 Summary
This PR introduces several improvements to the Practice Now feature, including emphasizing practiced phrases during sessions, enabling access to configuration for logged-out users, and refining call-to-action clarity. Additionally, it adds voice session configuration capabilities and supports deep-linking directly to the dashboard for enhanced user navigation.
🔗 Related Tasks
#8ff3408 - Emphasize practiced phrase + cover login flows
#2f09e05 - Open config to logged-out users + clearer CTAs
#db1a3fc - Voice session config + dashboard deep-link
📝 Additional Details
These changes collectively improve user experience by making practice sessions more interactive and accessible, streamlining user onboarding and login, and enhancing navigation through deep links to key parts of the application.
📜 Commit List
8ff3408 feat(practice-now): emphasize practiced phrase + cover login flows
2f09e05 feat(practice-now): open config to logged-out users + clearer CTAs
db1a3fc feat(practice-now): voice session config + dashboard deep-link