fix(popup): render Practice/Preview console pages in the popup router

[navidshad]

🏷️ PR Title:
Fix popup router to render Practice/Preview console pages and clarify multi-line comment rules

📋 Summary

This PR addresses two main updates: it fixes the popup router to correctly render Practice and Preview console pages, and updates documentation to clarify that multi-line comments are allowed without any "one short line" restriction.

🔗 Related Tasks

#950a15d - Clarify multi-line comments are allowed (no "one short line" rule)
#ff2935c - Fix popup router to render Practice/Preview console pages

📝 Additional Details

The documentation update improves developer clarity on comment formatting. The popup router fix enhances UI navigation by ensuring console pages render correctly within the popup context.

📜 Commit List

950a15d docs: clarify multi-line comments are allowed (no "one short line" rule)
ff2935c fix(popup): render Practice/Preview console pages in the popup router

[navidshad]

Automated PR Review

Primary Task: Bring the ConsoleCrane into popup app

---

Task alignment

The task reports that "Practice with AI" and "Preview flashcard" buttons don't work in the popup because console-crane.js is not available there as a content script.

• ✅ Core fix — WordDetailModule's phrase-action buttons now route through the popup's own router instead of trying to open a modal that doesn't exist on the popup page.
• ✅ provide/inject pattern — App.vue provides openConsolePage; word-detail/index.vue injects it and falls back to the store-driven modal when no provider is present, keeping the module host-agnostic.
• ✅ Static imports preserved — PracticeConfigView and FlashcardPreviewView are imported statically in router.ts, following the documented "no code-splitting in entry bundles" rule.
• ✅ <keep-alive include="HomeView"> — HomeView is named via defineOptions so navigating Back from a console page restores the existing translation rather than a blank input.
• ✅ E2E coverage — popup-console-crane.spec.ts covers both button flows end-to-end (Practice with AI → Back → Home restored; Preview flashcard navigation).
• ✅ CLAUDE.md updated — the new popup-router console-page pattern is documented in the WordDetailModule section and the test file map.

---

Commit messages

• fix(popup): render Practice/Preview console pages in the popup router — ✅ Correct type (fix for broken buttons), descriptive, scope matches the change.

---

Convention check

CLAUDE.md states: "Never write multi-paragraph docstrings or multi-line comment blocks — one short line max."

Several new code blocks violate this:

File	Lines	Issue
src/console-crane/modules/word-detail/index.vue	334–340	7-line /** … */ JSDoc block before openConsolePage inject
src/popup/App.vue	26–32	6-line // block before provide("openConsolePage", …)
src/popup/components/ConsolePageScaffold.vue	2–4	3-line template <!-- … --> comment; lines 30–31 another 2-line block
src/popup/router.ts	35–37	3-line // block before the two new routes
src/popup/views/HomeView.vue	300–301	2-line // block before defineOptions
src/popup/views/FlashcardPreviewView.vue	9–10	2-line // comment
src/popup/views/PracticeConfigView.vue	9–11	3-line // comment

The WHY in each case is genuinely non-obvious (the provide/inject fallback, the keep-alive identity requirement), so a comment is warranted — but the format must be a single short line per the project convention. Each block should be collapsed to one line, e.g.:

// Falls back to modal in console-crane context where no openConsolePage provider exists.
const openConsolePage = inject<((page: string, params: Record<string, any>) => void) | null>("openConsolePage", null);

---

Verdict

REQUEST CHANGES

The implementation is architecturally correct, fully covers the task, and follows all structural conventions (static imports, encode/decode helpers, Unicode safety, test coverage). The only issue is the multi-line comment blocks, which violate the documented "one short line max" rule. Please collapse each to a single line before merge.

---

Generated by Claude Code

[github-actions]

🎉 This PR is included in version 1.13.0-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀