Conversation
…acking gaps
- Rename legacy names: 'Word hovered' -> phrase_hovered, 'Definition
translated' -> definition_translated, 'Error on initiating' ->
extension_init-failed. Old prod data stays under the old names.
- Add phrase_clicked { word, platform } in Word.vue — the doc's core
interaction event was never fired.
- Add user_logged-in on explicit login success (popup LoginView);
session restores do not fire it.
- Pass userId to translateWithContext so the server can fire the
translation_requested server-truth event.
…load The analytics commit imported `authentication` from plugins/modular-rest, which runs GlobalOptions.set() plus chrome listeners and profile-store wiring at module load. Three unit suites (translate.service, nibble-surface, selection-popup) mock @modular-rest/client with only `functionProvider`, so pulling in the plugin threw "No GlobalOptions export is defined on the mock" and the files failed to load — yarn test dropped from 138 to 124. Import `authentication` straight from @modular-rest/client (the same singleton the plugin re-exports, and how functionProvider is already imported in this file) and stub it in the three mocks. No plugin side-effects in the service. yarn test back to 138/138; typecheck clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
Collaborator
Author
Automated PR ReviewPrimary Task: Close analytics gaps against docs/metrics: convention names, missing events, Stripe-webhook lifecycle Task alignmentThe diff is correctly scoped to the extension subtask
The other two sibling subtasks (dashboard frontend Commit messages
Convention check
VerdictAPPROVE All subtask requirements for the extension scope are fully implemented and correct. The one structural issue (missing Generated by Claude Code |
navidshad
changed the title
|
🎉 This PR is included in version 1.13.0-dev.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.14.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷️ PR Title: Align Analytics Events with Documentation and Fix Unit Test Imports
📋 Summary
This PR enhances the analytics module by aligning event tracking with official documentation and metrics conventions, closing existing tracking gaps. It also fixes the import of the authentication module from the client library to ensure unit test suites load correctly. Additionally, the
.gitignorefile is updated to exclude.agentfiles.🔗 Related Tasks
#902436f - Fix (analytics): import authentication from client lib so unit suites load
#6e3236e - Feat (analytics): align events with docs/metrics conventions, close tracking gaps
📝 Additional Details
.gitignoreto add.agententries to avoid committing agent files.📜 Commit List
c0eebf4 tweak gitignore to add .agent
902436f fix(analytics): import authentication from client lib so unit suites load
6e3236e feat(analytics): align events with docs/metrics conventions, close tracking gaps