Conversation
Add a Verifying changes section establishing the chrome-extension-tester (Playwright) MCP as the default per-change verification tool (local + CCW), with cross-links from the Cloud agent workflow, Verification checklist, and Useful pointers sections. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…acking gaps
- Rename legacy names: 'Word hovered' -> phrase_hovered, 'Definition
translated' -> definition_translated, 'Error on initiating' ->
extension_init-failed. Old prod data stays under the old names.
- Add phrase_clicked { word, platform } in Word.vue — the doc's core
interaction event was never fired.
- Add user_logged-in on explicit login success (popup LoginView);
session restores do not fire it.
- Pass userId to translateWithContext so the server can fire the
translation_requested server-truth event.
…load The analytics commit imported `authentication` from plugins/modular-rest, which runs GlobalOptions.set() plus chrome listeners and profile-store wiring at module load. Three unit suites (translate.service, nibble-surface, selection-popup) mock @modular-rest/client with only `functionProvider`, so pulling in the plugin threw "No GlobalOptions export is defined on the mock" and the files failed to load — yarn test dropped from 138 to 124. Import `authentication` straight from @modular-rest/client (the same singleton the plugin re-exports, and how functionProvider is already imported in this file) and stub it in the three mocks. No plugin side-effects in the service. yarn test back to 138/138; typecheck clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…gaps-against-docsmetrics-convention-names-missing-events-Stripe-webhook-lifecycle_Navid-Shad Title: Align Analytics Events with Documentation and Fix Unit Test Imports #86exvrzy8
# [1.13.0-dev.3](v1.13.0-dev.2...v1.13.0-dev.3) (2026-06-08) ### Bug Fixes * **analytics:** import authentication from client lib so unit suites load ([902436f](902436f)) ### Features * **analytics:** align events with docs/metrics conventions, close tracking gaps ([6e3236e](6e3236e))
Collaborator
Author
navidshad
changed the title
# [1.14.0-dev.1](v1.13.0...v1.14.0-dev.1) (2026-06-08) ### Bug Fixes * **analytics:** import authentication from client lib so unit suites load ([902436f](902436f)) ### Features * **analytics:** align events with docs/metrics conventions, close tracking gaps ([6e3236e](6e3236e))
|
🎉 This PR is included in version 1.14.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Collaborator
Author
Automated PR ReviewPrimary Task: Close analytics gaps against docs/metrics: convention names, missing events, Stripe-webhook lifecycle Task alignmentThe PR covers the extension-scoped subtask (86exvrzza) only — the dashboard and server subtasks (86exvt00m, 86exvt01x) belong to other repos, as expected.
Commit messages
Prior review follow-upNo prior automated or manual review requests on this PR. Convention check
VerdictAPPROVE The extension subtask is fully and correctly addressed: all required renames are done, all missing events are added, test mocks are in sync, and docs are updated. The one flagged commit message ( Generated by Claude Code |
Collaborator
Author
Automated PR ReviewPrimary Task: CU-86exvrzy8 — Close analytics gaps against docs/metrics: convention names, missing events, Stripe-webhook lifecycle Task alignmentThe PR covers exactly the extension subtask (CU-86exvrzza). All six deliverables are present:
The dashboard subtask (CU-86exvt00m) and Stripe-webhook subtask (CU-86exvt01x) are explicitly out of scope for this repo — correct. Commit messages
Prior review follow-upNo prior reviews on this PR. Convention check
VerdictAPPROVE All subtask requirements are fully implemented, the right files were touched, test mocks are correct, and the code follows project conventions. The only friction is the one commit missing its type prefix ( Generated by Claude Code |
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷️ PR Title: Align Analytics Events with Docs/Metrics Conventions and Fix Tracking Gaps
📋 Summary
This PR updates analytics event tracking to align with documentation and metrics conventions, addressing missing events and closing existing tracking gaps. It also fixes issues related to importing authentication in unit test suites and updates the gitignore to include
.agent. Additionally, the Chrome Extension Tester MCP is set as the default verification workflow.🔗 Related Tasks
📝 Additional Details
.gitignoreto include.agentfiles.📜 Commit List