Fix SelectPhraseBundleV2 dropdown close in modal context#36
Closed
navidshad wants to merge 1 commit into
Closed
Conversation
…st #86exzbh61 The save-phrase bundle selector (a pilotui Select in custom+multiple mode) would not close and its option list spilled out of the modal. - Close: pilotui's only outside-driven close is a document handler that bails whenever the click sits under any `.relative` ancestor — true for nearly every click inside the ConsoleCrane modal, so the dropdown never closed. pilotui exposes no close method or `open` prop, so drive its own Escape handler from a self-managed outside-pointerdown listener and a real closeDropdown() (the latter also wired up the previously no-op after-save close called by SaveWordSectionV2). - Overflow: pilotui only gives the option list an internal scroll in `confirm` mode; in the `custom` mode used here the list grows past the panel's max-height and out of the modal. Make the panel a flex column and let the list region scroll within it. Adds a happy-dom regression test for the close mechanism. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JsGMdHrjQfWRausa9T14kw
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷️ PR Title:
Fix console crane bundle selector dropdown behavior
📋 Summary
This PR addresses the issue with the bundle selector dropdown in the console crane by ensuring that the dropdown closes properly and its list is contained within the dropdown area to improve UI behavior and prevent overflow.
🔗 Related Tasks
#86exzbh61 - Close bundle selector dropdown and contain its list
📝 Additional Details
The changes improve the user experience by preventing the dropdown list from extending outside its container and ensuring it closes on selection or when losing focus.
📜 Commit List
f9f1c8e fix(console-crane): close bundle selector dropdown and contain its list #86exzbh61