Skip to content

Fix bundle selector dropdown overflow in save phrase modal#38

Merged
navidshad merged 7 commits into
mainfrom
dev
Jun 17, 2026
Merged

Fix bundle selector dropdown overflow in save phrase modal#38
navidshad merged 7 commits into
mainfrom
dev

Conversation

@navidshad

@navidshad navidshad commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

🏷️ PR Title: Fix bundle selector dropdown overflow in save phrase modal

📋 Summary

This PR resolves issues with the bundle selector dropdown in the save phrase modal by ensuring the bundle list stays contained within the modal frame and the dropdown closes properly to prevent overflow.

🔗 Related Tasks

#86exzbh61 - Fix bundle selector dropdown in save phrase modal that won't close and overflows wrapper

📝 Additional Details

Also includes documentation updates on sibling repositories and cross-repo branch workflows to improve developer onboarding and collaboration.

📜 Commit List

ca49b14 fix(console-crane): keep bundle list within the modal frame #86exzbh61
f9f1c8e fix(console-crane): close bundle selector dropdown and contain its list #86exzbh61
2c84d80 docs: document sibling repos and cross-repo branch workflow
646094e Merge pull request #37 from codebridger/CU-86exzbh61_Fix-bundle-selector-dropdown-in-save-phrase-modal-wont-close-overflows-wrapper
5f7544b chore(release): 1.15.0-dev.2 [skip ci]
28ad779 Merge remote-tracking branch 'origin/main' into dev

navidshad and others added 6 commits June 17, 2026 13:58
Add a Sibling Repositories section to README.md and CLAUDE.md covering
subturtle-dashboard-app (server/dashboard) and pilotui, plus guidance for
agents to search/clone a sibling locally and work on a feature branch in
the sibling when a change is needed to verify this repo's branch.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…st #86exzbh61

The save-phrase bundle selector (a pilotui Select in custom+multiple mode)
would not close and its option list spilled out of the modal.

- Close: pilotui's only outside-driven close is a document handler that bails
  whenever the click sits under any `.relative` ancestor — true for nearly
  every click inside the ConsoleCrane modal, so the dropdown never closed.
  pilotui exposes no close method or `open` prop, so drive its own Escape
  handler from a self-managed outside-pointerdown listener and a real
  closeDropdown() (the latter also wired up the previously no-op after-save
  close called by SaveWordSectionV2).
- Overflow: pilotui only gives the option list an internal scroll in `confirm`
  mode; in the `custom` mode used here the list grows past the panel's
  max-height and out of the modal. Make the panel a flex column and let the
  list region scroll within it.

Adds a happy-dom regression test for the close mechanism.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JsGMdHrjQfWRausa9T14kw
The bundle list was capped at pilotui's max-h-96 with an internal scroll, but
the save section sits near the modal bottom, so the fixed downward panel still
ran past the visible frame — the user had to scroll the modal AND the list.

On open, measure the trigger against the nearest scroll frame and place the
absolutely-positioned panel accordingly: flip it upward when it can't fully open
downward and there's more room above, and cap its height to the available space
(minus a gap) in whichever direction it opens. Reposition on resize/scroll while
open; pilotui exposes no placement API, so this is done via inline styles on its
rendered panel. The list scrolls internally within the cap.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JsGMdHrjQfWRausa9T14kw
…tor-dropdown-in-save-phrase-modal-wont-close-overflows-wrapper

Fix SelectPhraseBundleV2 dropdown close in modal context
@navidshad

Copy link
Copy Markdown
Collaborator Author

## [1.15.1-dev.1](v1.15.0...v1.15.1-dev.1) (2026-06-17)

### Bug Fixes

* **console-crane:** close bundle selector dropdown and contain its list [#86](https://github.com/codebridger/subturtle-extension-apps/issues/86)exzbh61 ([f9f1c8e](f9f1c8e)), closes [#86exzbh61](https://github.com/codebridger/subturtle-extension-apps/issues/86exzbh61)
* **console-crane:** keep bundle list within the modal frame [#86](https://github.com/codebridger/subturtle-extension-apps/issues/86)exzbh61 ([ca49b14](ca49b14)), closes [#86exzbh61](https://github.com/codebridger/subturtle-extension-apps/issues/86exzbh61)
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.15.1-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@navidshad navidshad merged commit 1d3e81a into main Jun 17, 2026
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@navidshad navidshad changed the title Dev Fix bundle selector dropdown overflow in save phrase modal Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants