fix: publish amd64 and arm64 images#929
Open
surt91 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Docker image build and promotion workflow to support multi-platform images (amd64 and arm64 architectures). The changes enable proper building and promotion of container images for both platforms.
Key Changes
- Modified image promotion workflow to use
docker buildx imagetoolsfor multi-platform manifest handling - Added platform specification (linux/amd64, linux/arm64) to the image build workflow
- Added Docker Buildx setup and dependency on build-container-images job
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release-publish-chart-and-container-images.yaml | Updates image promotion to use buildx imagetools for multi-platform support and adds necessary job dependencies |
| .github/workflows/push_images.yaml | Adds platform specification to enable building both amd64 and arm64 images |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
surt91
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we are building both architectures in our release pipeline, but we did only promote the amd64 image.
This PR will ensure that both images are built and will promote both.