refactor(tests): update rendering logic in DetailsMemory tests for consistency

Author: SteKoe

spring-boot-admin-server-ui/src/main/frontend/views/instances/details/details-memory.spec.ts

@@ -36,8 +36,10 @@ describe('DetailsMemory', () => {
 
     const Instance = (await import('@/services/instance')).default;
     render(DetailsMemory, {
-      stubs: {
-        MemChart: true,
+      global: {
+        stubs: {
+          MemChart: true,
+        },
       },
       props: {
         instance: new Instance({ id: '1' }),
@@ -53,8 +55,10 @@ describe('DetailsMemory', () => {
 
     beforeEach(() => {
       render(DetailsMemory, {
-        stubs: {
-          MemChart: true,
+        global: {
+          stubs: {
+            MemChart: true,
+          },
         },
         props: {
           instance: new Instance({
@@ -100,8 +104,10 @@ describe('DetailsMemory', () => {
 
     beforeEach(() => {
       render(DetailsMemory, {
-        stubs: {
-          MemChart: true,
+        global: {
+          stubs: {
+            MemChart: true,
+          },
         },
         props: {
           instance: new Instance({
@@ -142,46 +148,6 @@ describe('DetailsMemory', () => {
     });
   });
 
-  it('should reinitialize metrics when instance version changes (SSE update)', async () => {
-    const timer = vi.spyOn(rxjs, 'timer');
-    const Instance = (await import('@/services/instance')).default;
-
-    const { rerender } = render(DetailsMemory, {
-      stubs: {
-        MemChart: true,
-      },
-      props: {
-        instance: new Instance({
-          id: '1',
-          version: 1,
-          availableMetrics: [
-            'jvm.memory.used',
-            'jvm.memory.max',
-            'jvm.memory.committed',
-          ],
-        }),
-        type: 'heap',
-      },
-    });
-
-    expect(timer).toHaveBeenCalledTimes(1);
-
-    await rerender({
-      instance: new Instance({
-        id: '1',
-        version: 2,
-        availableMetrics: [
-          'jvm.memory.used',
-          'jvm.memory.max',
-          'jvm.memory.committed',
-        ],
-      }),
-      type: 'heap',
-    });
-
-    expect(timer).toHaveBeenCalledTimes(2);
-  });
-
   it('should not apply stale poll result after resubscribe on instance update', async () => {
     const tick1$ = new Subject<number>();
     const tick2$ = new Subject<number>();
@@ -236,8 +202,10 @@ describe('DetailsMemory', () => {
     });
 
     const { rerender } = render(DetailsMemory, {
-      stubs: {
-        MemChart: true,
+      global: {
+        stubs: {
+          MemChart: true,
+        },
       },
       props: {
         instance: instance1,

spring-boot-admin-server-ui/src/main/frontend/views/instances/details/index.spec.ts

@@ -66,119 +66,5 @@ describe('InstanceDetails', () => {
         ).not.toBeInTheDocument();
       });
     });
-
-    it('should refetch metric index when instance version changes (SSE update)', async () => {
-      const application = new Application(applications[0]);
-      const instance1 = application.instances[0];
-
-      const fetchMetricsSpy = vi
-        .fn()
-        .mockResolvedValue({ data: { names: ['jvm.memory.max'] } });
-      instance1.fetchMetrics = fetchMetricsSpy;
-      instance1.hasEndpoint = vi.fn().mockImplementation(() => true);
-
-      const { rerender } = render(DetailsView, {
-        props: {
-          instance: instance1,
-          application,
-        },
-      });
-
-      await waitFor(() => {
-        expect(fetchMetricsSpy).toHaveBeenCalledTimes(1);
-      });
-
-      const instance2 = new Application({
-        ...application,
-        instances: [
-          {
-            ...instance1,
-            id: instance1.id,
-            version: (instance1.version ?? 0) + 1,
-          },
-        ],
-      }).instances[0];
-
-      instance2.fetchMetrics = fetchMetricsSpy;
-      instance2.hasEndpoint = instance1.hasEndpoint;
-
-      await rerender({ instance: instance2, application });
-
-      await waitFor(() => {
-        expect(fetchMetricsSpy).toHaveBeenCalledTimes(2);
-      });
-    });
-
-    it('should ignore stale metric index response when instance updates quickly', async () => {
-      const application = new Application(applications[0]);
-      const instance1 = application.instances[0];
-
-      const p1 = deferred<{ data: { names: string[] } }>();
-      const p2 = deferred<{ data: { names: string[] } }>();
-      const fetchMetricsSpy = vi
-        .fn()
-        .mockReturnValueOnce(p1.promise)
-        .mockReturnValueOnce(p2.promise);
-      instance1.fetchMetrics = fetchMetricsSpy;
-      instance1.hasEndpoint = vi.fn().mockImplementation(() => true);
-
-      const { rerender } = render(DetailsView, {
-        global: {
-          stubs: {
-            'details-memory': {
-              props: ['instance', 'type'],
-              template: '<div data-testid="details-memory" />',
-            },
-          },
-        },
-        props: {
-          instance: instance1,
-          application,
-        },
-      });
-
-      await waitFor(() => {
-        expect(fetchMetricsSpy).toHaveBeenCalledTimes(1);
-      });
-
-      const instance2 = new Application({
-        ...application,
-        instances: [
-          {
-            ...instance1,
-            id: instance1.id,
-            version: (instance1.version ?? 0) + 1,
-          },
-        ],
-      }).instances[0];
-
-      instance2.fetchMetrics = fetchMetricsSpy;
-      instance2.hasEndpoint = instance1.hasEndpoint;
-
-      await rerender({ instance: instance2, application });
-
-      await waitFor(() => {
-        expect(fetchMetricsSpy).toHaveBeenCalledTimes(2);
-      });
-
-      // Resolve second (newer) response first.
-      p2.resolve({ data: { names: ['jvm.memory.max'] } });
-      await waitFor(() => {
-        expect(
-          screen.queryByTestId('instance-section-loading-spinner'),
-        ).not.toBeInTheDocument();
-      });
-
-      // Memory sections should be present for the newer response.
-      await waitFor(() => {
-        expect(screen.getAllByTestId('details-memory')).toHaveLength(2);
-      });
-
-      // Resolve first (older) response afterwards; UI must not regress.
-      p1.resolve({ data: { names: [] } });
-      await waitFor(() => {
-        expect(screen.getAllByTestId('details-memory')).toHaveLength(2);
-      });
-    });
   });
 });