Skip to content

Commit cdf2619

Browse files
cdpreteSteKoe
andauthored
fix(#5307): make the LineChart component have a proper parent width (#5346)
Co-authored-by: Stephan Köninger <stephan.koeninger@codecentric.de>
1 parent e4944d2 commit cdf2619

3 files changed

Lines changed: 35 additions & 16 deletions

File tree

spring-boot-admin-server-ui/src/main/frontend/views/instances/details/LineChart.vue

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@
1515
-->
1616

1717
<template>
18-
<canvas id="chart" ref="chart" />
18+
<div class="chart-container">
19+
<canvas id="chart" ref="chart" />
20+
</div>
1921
</template>
2022

2123
<script>
@@ -115,6 +117,8 @@ export default {
115117
datasets,
116118
},
117119
options: {
120+
responsive: true,
121+
maintainAspectRatio: false,
118122
animation: {
119123
duration: 0,
120124
},
@@ -192,3 +196,13 @@ export default {
192196
},
193197
};
194198
</script>
199+
200+
<style scoped>
201+
.chart-container {
202+
position: relative;
203+
width: 100%;
204+
min-height: 300px;
205+
max-height: 450px;
206+
height: 100%;
207+
}
208+
</style>

spring-boot-admin-server-ui/src/main/frontend/views/instances/details/index.vue

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,44 +21,44 @@
2121
<details-hero :instance="instance" />
2222
</template>
2323

24-
<div class="flex gap-6 flex-col lg:flex-row">
25-
<div class="flex-1">
24+
<div class="instance-grid">
25+
<div>
2626
<details-info v-if="hasInfo" :instance="instance" />
2727
<details-metadata v-if="hasMetadata" :instance="instance" />
2828
</div>
29-
<div class="flex-1">
29+
<div>
3030
<details-health :instance="instance" />
3131
</div>
3232
</div>
3333

34-
<div class="flex gap-6 flex-col lg:flex-row">
35-
<div class="flex-1">
34+
<div class="instance-grid">
35+
<div>
3636
<details-process
3737
v-if="hasProcess"
3838
:instance="instance"
3939
class="break-inside-avoid"
4040
/>
4141
<details-gc v-if="hasGc" :instance="instance" />
4242
</div>
43-
<div class="flex-1">
43+
<div>
4444
<details-threads v-if="hasThreads" :instance="instance" />
4545
</div>
4646
</div>
4747

48-
<div class="flex gap-6 flex-col lg:flex-row">
49-
<div class="flex-1">
48+
<div class="instance-grid">
49+
<div>
5050
<details-memory v-if="hasMemory" :instance="instance" type="heap" />
5151
</div>
52-
<div class="flex-1">
52+
<div>
5353
<details-memory v-if="hasMemory" :instance="instance" type="nonheap" />
5454
</div>
5555
</div>
5656

57-
<div class="flex gap-6 flex-col lg:flex-row">
58-
<div class="flex-1">
57+
<div class="instance-grid">
58+
<div>
5959
<details-datasources v-if="hasDatasources" :instance="instance" />
6060
</div>
61-
<div class="flex-1">
61+
<div>
6262
<details-caches v-if="hasCaches" :instance="instance" />
6363
</div>
6464
</div>
@@ -204,3 +204,11 @@ export default {
204204
},
205205
};
206206
</script>
207+
208+
<style scoped>
209+
@reference "../../../index.css";
210+
211+
.instance-grid {
212+
@apply grid grid-cols-1 lg:grid-cols-2 gap-4;
213+
}
214+
</style>

spring-boot-admin-server-ui/src/main/frontend/views/instances/details/instance-switcher.vue

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,3 @@ export default {
107107
},
108108
};
109109
</script>
110-
111-
<style scoped></style>
112-
@reference "../../../index.css";

0 commit comments

Comments
 (0)