chore: fix lack of test resources when npm build is skip#5303
Merged
Conversation
cdprete
force-pushed
the
chore/fix-tests-run
branch
from
8e0b5c0 to
1747e56
Compare
cdprete
force-pushed
the
chore/fix-tests-run
branch
2 times, most recently
from
9ce8333 to
7f7f8b6
Compare
cdprete
force-pushed
the
chore/fix-tests-run
branch
10 times, most recently
from
af0d9c0 to
db4d90d
Compare
cdprete
force-pushed
the
chore/fix-tests-run
branch
3 times, most recently
from
453148b to
5379182
Compare
cdprete
force-pushed
the
chore/fix-tests-run
branch
from
5379182 to
8b6f363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the lack of resources (e.g.:
sba-settings.js) when the tests are executed with-PnoNpm.The issue with some tests failing was reported in #5285 (comment) and this PR fixes it.
The needed resources have been generated once and made them available under
target/classes, as opposite of the defaulttarget/testClasses, to not change the existing tests which, by relying on the default configuration, they expect to load them from the class resources instead of from the test class ones.By the way, thefrontend-maven-pluginalso fails with the same issue reported in eirslett/frontend-maven-plugin#1178 😞EDIT: the point above about
npmis solved with #5312