fix(#5307): make the LineChart component have a proper parent width#5346
Merged
Conversation
cdprete
force-pushed
the
fix/5307
branch
8 times, most recently
from
2ebbd90 to
2c07af9
Compare
Contributor
|
Hi, I switched to grid instead of flex box in instances/details view which enforces a fixed column width of 50%. This also forces chart.js to render the width for charts as expected. Since the option to maintain aspect ratio leads to decreased height of charts, I disabled this as well. Now, when resizing the window, charts are drawn nicely and the respective containers do not exceed their boundaries and lead to nasty layouting. |
SteKoe
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #5307.
The issue still occurs, as it can be seen below:
but it's way less evident than the previous one shown in #5307 (comment).
It's like, on rendering, it can't detect the width of the parent properly (by a small margin) when it's added to the DOM by opening the accordion, in constrast with when it's already in the DOM to begin with.
I was considering to try with
resizeDelaybut I don't know how much it's worthy.