fix: guard sort() with shuffle check so --shuffle is not silently ignored

[kapil971390]

Fixes #5605

What

run() calls this.testFiles.sort() unconditionally after loadTests() has already applied shuffle() when --shuffle is set. The sort overwrites the randomised order every time, making --shuffle silently have no effect.

// loadTests() — line 217
if (this.opts.shuffle) {
  this.testFiles = shuffle(this.testFiles)  // ✅ shuffled
}

// run() — line 293 (added by #5438)
this.testFiles.sort()  // ❌ always runs — shuffle is lost

Fix

Guard the sort with !this.opts.shuffle:

// Sort alphabetically for consistent order, but preserve shuffle when active.
if (!this.opts.shuffle) {
  this.testFiles.sort()
}

Normal runs continue to get alphabetical order. --shuffle runs now keep their randomised order.

Why this happened

The sort() was introduced in #5438 to fix worker suite distribution — a correct fix for that issue, but it introduced this regression for --shuffle users.

Change

Single guard condition in lib/codecept.js — no other behaviour changed.

[kapil971390]

Hi! Could a maintainer approve the workflows to run CI on this? The fix is a single guard condition in lib/codecept.js — happy to answer any questions.

[kapil971390]

All relevant checks passing. appium failures are pre-existing, saucelabs infrastructure issues, unrelated to this change.

[DavertMik]

Thank you for catching it!