Conversation
|
This PR includes changes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 492 492
Lines 16876 16877 +1
=======================================
+ Hits 16188 16189 +1
Misses 688 688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joseph-sentry
temporarily deployed
to
staging
GitHub Actions
Inactive
joseph-sentry
force-pushed
the
joseph/update-shared
branch
2 times, most recently
from
35094d4 to
0c14dc9
Compare
|
This PR includes changes to |
| raise Http404("Requested report could not be found") | ||
| return repo | ||
|
|
||
| @sync_to_async |
There was a problem hiding this comment.
this change looks unrelated. why?
if the function was sync all along, there is no reason to make it async? the function body looks trivial enough that it wouldn’t benefit from running concurrently.
There was a problem hiding this comment.
this is a workaround because now the initialization of ArchiveService involves feature flags which involves Django queries which can't run in an async context by default
sync_to_async allows us to make django queries in an async context
| mocked_task_service = mocker.patch.object(TaskService, "schedule_task") | ||
| mocked_presigned_put = mocker.patch( | ||
| "shared.api_archive.archive.StorageService.create_presigned_put", | ||
| "shared.storage.MinioStorageService.create_presigned_put", |
There was a problem hiding this comment.
as we have discussed in the retro, related to "overreliance on mocks", keep in mind that all of these mocks are potential breakage in production that we will never catch in tests :-(
There was a problem hiding this comment.
I made an issue to remove these, but i'd like to get this PR in so we don't fall too behind compared to shared
joseph-sentry
force-pushed
the
joseph/update-shared
branch
from
0c14dc9 to
2a62c8a
Compare
joseph-sentry
temporarily deployed
to
staging
GitHub Actions
Inactive
3 participants
No description provided.