This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Adjust call used in comparison file to avoid provider api call#1176
Merged
adrian-codecov merged 2 commits intomainfrom Feb 27, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
- Coverage 95.92% 95.88% -0.04%
==========================================
Files 492 492
Lines 16876 16879 +3
==========================================
- Hits 16188 16185 -3
- Misses 688 694 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nora-shap
approved these changes
Feb 26, 2025
adrian-codecov
commented
Feb 26, 2025
| if "comparison" not in info.context: | ||
| return False | ||
| comparison: Comparison = info.context["comparison"] | ||
| try: |
Contributor
Author
There was a problem hiding this comment.
Didnt specify but this is implicitly moved in the try/except inside the resolver logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
This PR intends to improve loading times in the Pull detail page by adjusting the logic in the
has_different_number_of_head_and_base_reportsresolver.Links to relevant tickets
This is one of the many resolvers I'd like to tackle with the investigation done here.
What does this PR do?
This resolver calls the comparison.head_report, which always calls the
apply_difffunction, which ends up calling the provider. In some cases, this call is necessary, but for this particular resolver it is not as the logic inside the resolver compares number of sessions, not the contents of the sessions. Therefore, we're going to shave some time by adding a property that doesn't talk to the provider.I left note in that implementation, there's an opportunity to improve the algorithm altogether and use the DB only instead of GCS.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.