Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Revert "feat: Track Upload Sent events for Coverage/BA/TA (#1162)"#1194

Merged
spalmurray-codecov merged 1 commit intomainfrom
spalmurray/revert-upload-apm
Mar 4, 2025
Merged

Revert "feat: Track Upload Sent events for Coverage/BA/TA (#1162)"#1194
spalmurray-codecov merged 1 commit intomainfrom
spalmurray/revert-upload-apm

Conversation

@spalmurray-codecov
Copy link
Copy Markdown
Contributor

@spalmurray-codecov spalmurray-codecov commented Mar 4, 2025

This reverts commit b43c765.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review March 4, 2025 20:14
@spalmurray-codecov spalmurray-codecov requested a review from a team as a code owner March 4, 2025 20:14
@sentry
Copy link
Copy Markdown

sentry bot commented Mar 4, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: upload/views/uploads.py

Function Unhandled Issue
send_analytics_data AttributeError: 'NoneType' object has no attribute 'ownerid' /upload/{service}/{repo}/upl...
Event Count: 34
send_analytics_data AttributeError: 'NoneType' object has no attribute 'ownerid' /upload/{service}/{repo}/commits/{commit_sha}/reports/{report_c...
Event Count: 19

Did you find this useful? React with a 👍 or 👎

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Mar 4, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (b43c765) to head (7b5b8c5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
- Coverage   95.88%   95.88%   -0.01%     
==========================================
  Files         493      493              
  Lines       16857    16851       -6     
==========================================
- Hits        16163    16157       -6     
  Misses        694      694              
Flag Coverage Δ
unit 95.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Merged via the queue into main with commit 5dc7191 Mar 4, 2025
27 of 28 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/revert-upload-apm branch March 4, 2025 20:25
@JerrySentry JerrySentry restored the spalmurray/revert-upload-apm branch March 12, 2025 13:45
JerrySentry added a commit that referenced this pull request Mar 12, 2025
@overwatch-beta
Copy link
Copy Markdown

overwatch-beta bot commented Mar 12, 2025

🚨 Sentry detected 5 potential issues in your recent changes 🚨

Lower risk findings

JerrySentry added a commit that referenced this pull request Mar 18, 2025
@seer-by-sentry
Copy link
Copy Markdown
Contributor

✅ Sentry found no issues in your recent changes ✅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants