Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

fix: pass repoid to get_appropriate_storage_service#1209

Merged
joseph-sentry merged 1 commit intomainfrom
joseph/fix
Mar 12, 2025
Merged

fix: pass repoid to get_appropriate_storage_service#1209
joseph-sentry merged 1 commit intomainfrom
joseph/fix

Conversation

@joseph-sentry
Copy link
Copy Markdown
Contributor

if we don't pass the repoid, then it won't check the feature flag, and it will be stuck on the old implementation

so it's possible that somewhere else the file is being written using the new implementation, so this will fail to decompress it properly

this is just temporary until we hardcode the new impl to be the default

if we don't pass the repoid, then it won't check the feature flag, and
it will be stuck on the old implementation

so it's possible that somewhere else the file is being written using
the new implementation, so this will fail to decompress it properly

this is just temporary until we hardcode the new impl to be the
default
@joseph-sentry joseph-sentry requested a review from a team as a code owner March 12, 2025 20:30
@seer-by-sentry
Copy link
Copy Markdown
Contributor

seer-by-sentry bot commented Mar 12, 2025

🚨 Sentry detected 10 potential issues in your recent changes 🚨

Lower risk findings

@joseph-sentry joseph-sentry enabled auto-merge March 12, 2025 20:34
@joseph-sentry joseph-sentry added this pull request to the merge queue Mar 12, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (0fbad61) to head (c790a32).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1209   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         493      493           
  Lines       16880    16880           
=======================================
  Hits        16183    16183           
  Misses        697      697           
Flag Coverage Δ
unit 95.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 8d9cd04 Mar 12, 2025
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix branch March 12, 2025 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants