This repository was archived by the owner on Jun 13, 2025. It is now read-only.
fix: pass repoid to get_appropriate_storage_service#1209
Merged
joseph-sentry merged 1 commit intomainfrom Mar 12, 2025
Merged
Conversation
if we don't pass the repoid, then it won't check the feature flag, and it will be stuck on the old implementation so it's possible that somewhere else the file is being written using the new implementation, so this will fail to decompress it properly this is just temporary until we hardcode the new impl to be the default
Contributor
🚨 Sentry detected 10 potential issues in your recent changes 🚨Lower risk findings
|
spalmurray-codecov
approved these changes
Mar 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 493 493
Lines 16880 16880
=======================================
Hits 16183 16183
Misses 697 697
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if we don't pass the repoid, then it won't check the feature flag, and it will be stuck on the old implementation
so it's possible that somewhere else the file is being written using the new implementation, so this will fail to decompress it properly
this is just temporary until we hardcode the new impl to be the default