This repository was archived by the owner on Jun 13, 2025. It is now read-only.
fix: replace NaN values in deduped TA table#1211
Merged
joseph-sentry merged 1 commit intomainfrom Mar 19, 2025
Merged
Conversation
Contributor
🚨 Sentry detected 10 potential issues in your recent changes 🚨Lower risk findings
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 492 492
Lines 16810 16814 +4
=======================================
+ Hits 16190 16194 +4
Misses 620 620
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ajay-sentry
reviewed
Mar 18, 2025
| * (pl.col("total_pass_count") + pl.col("total_fail_count")) | ||
| ).sum() / (pl.col("total_pass_count") + pl.col("total_fail_count")).sum() | ||
|
|
||
| # dedup |
Contributor
There was a problem hiding this comment.
very helpful comment ;)
joseph-sentry
force-pushed
the
joseph/fix-ta
branch
2 times, most recently
from
468a702 to
e604c8d
Compare
joseph-sentry
force-pushed
the
joseph/fix-ta
branch
from
e604c8d to
9d146d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 things: