Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

add impersonation styling to django admin#1214

Merged
nora-shap merged 1 commit intomainfrom
nora/3465
Mar 19, 2025
Merged

add impersonation styling to django admin#1214
nora-shap merged 1 commit intomainfrom
nora/3465

Conversation

@nora-shap
Copy link
Copy Markdown
Member

Purpose/Motivation

If you use the django admin site while impersonating, it gets ugly (becomes very visually apparent that you are in an altered state)

Links to relevant tickets

codecov/engineering-team#3465

preview from my local (the banner got cut off, it says Impersonating (return to codecov.io and log out)):

Screenshot 2025-03-17 at 5 13 14 PM

@nora-shap nora-shap requested a review from a team March 18, 2025 00:22
@seer-by-sentry
Copy link
Copy Markdown
Contributor

seer-by-sentry bot commented Mar 18, 2025

✅ Sentry found no issues in your recent changes ✅

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (b4563c1) to head (6b90630).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         493      493           
  Lines       16877    16877           
=======================================
  Hits        16180    16180           
  Misses        697      697           
Flag Coverage Δ
unit 95.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@nora-shap nora-shap added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 8cd5abc Mar 19, 2025
23 of 24 checks passed
@nora-shap nora-shap deleted the nora/3465 branch March 19, 2025 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants