Conversation
Previously, the `owner.repository` resolver would unconditionally execute a very complicated query through `fetch_repository`. We can avoid that expensive subquery by inspecting the requested fields as stated in the graphql query.
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
- Coverage 96.33% 96.32% -0.02%
==========================================
Files 492 493 +1
Lines 16898 16933 +35
==========================================
+ Hits 16278 16310 +32
- Misses 620 623 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
joseph-sentry
left a comment
There was a problem hiding this comment.
i would just leave a comment in the requested_fields.py to look at graphql/language/parser.py to understand what's going on there
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Previously, the
owner.repositoryresolver would unconditionally execute a very complicated query throughfetch_repository.We can avoid that expensive subquery by inspecting the requested fields as stated in the graphql query.
This might fix codecov/engineering-team#3396