This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Conversation
By looking at some random traces, I found that the functions being traced were only *creating* querysets, but they were not the functions that actually *evaluated* those querysets.
Swatinem
commented
Apr 2, 2025
| if exclude_okta_enforced_repos: | ||
| queryset = queryset.exclude_accounts_enforced_okta(okta_account_auths) | ||
|
|
||
| if not ai_enabled_filter: |
Contributor
Author
There was a problem hiding this comment.
no to reviewers: expand the code above this change, and you will see that we early-return if ai_enabled_filter above, so this branch here was always true.
Contributor
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
- Coverage 96.32% 96.32% -0.01%
==========================================
Files 493 493
Lines 16933 16932 -1
==========================================
- Hits 16310 16309 -1
Misses 623 623
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joseph-sentry
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By looking at some random traces, I found that the functions being traced were only creating querysets, but they were not the functions that actually evaluated those querysets.