Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Move trace annotation to correct fn #1265

Merged
Swatinem merged 1 commit into from
Apr 2, 2025
Merged

Move trace annotation to correct fn #1265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions graphql_api/actions/repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import logging
from typing import Any

import sentry_sdk
from django.db.models import QuerySet
from shared.django_apps.codecov_auth.models import GithubAppInstallation, Owner
from shared.django_apps.core.models import Repository
Expand Down Expand Up @@ -54,7 +53,6 @@ def filter_queryset_by_ai_enabled_repos(queryset: QuerySet, owner: Owner) -> Que
return queryset


@sentry_sdk.trace
def list_repository_for_owner(
current_owner: Owner,
owner: Owner,
Expand All @@ -72,16 +70,13 @@ def list_repository_for_owner(
if exclude_okta_enforced_repos:
queryset = queryset.exclude_accounts_enforced_okta(okta_account_auths)

if not ai_enabled_filter:
Copy link
Copy Markdown
Contributor Author

@Swatinem Swatinem Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no to reviewers: expand the code above this change, and you will see that we early-return if ai_enabled_filter above, so this branch here was always true.

queryset = (
queryset.with_recent_coverage().with_latest_commit_at().filter(author=owner)
)

queryset = (
queryset.with_recent_coverage().with_latest_commit_at().filter(author=owner)
)
queryset = apply_filters_to_queryset(queryset, filters, owner)
return queryset


@sentry_sdk.trace
def search_repos(
current_owner: Owner,
filters: dict[str, Any] | None,
Expand Down
2 changes: 2 additions & 0 deletions graphql_api/types/me/me.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from typing import Optional

import sentry_sdk
from ariadne import ObjectType
from asgiref.sync import sync_to_async
from graphql import GraphQLResolveInfo
Expand Down Expand Up @@ -41,6 +42,7 @@ def resolve_owner(user, _):


@me_bindable.field("viewableRepositories")
@sentry_sdk.trace
def resolve_viewable_repositories(
current_user,
info: GraphQLResolveInfo,
Expand Down
1 change: 1 addition & 0 deletions graphql_api/types/owner/owner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@

@owner_bindable.field("repositories")
@sync_to_async
@sentry_sdk.trace
def resolve_repositories(
owner: Owner,
info: GraphQLResolveInfo,
Expand Down