Use the CommitLoader for bundleAnalysisCompareWithParent

[Swatinem]

This is loading the parent_commit using the async batch-loading CommitLoader.

This way, we can avoid one of the N+1 queries being executed when executing the GetCommits GraphQL query.

However, we are still loading all the BA CommitReports separately within load_bundle_analysis_comparison, which is another 2N+1 problem on its own. Will solve that one another time :-)

[seer-by-sentry]

✅ Sentry found no issues in your recent changes ✅

[adrian-codecov]

Can you explain a bit more how making the call async to load_... helps w/ the N+1?

[Swatinem]

https://github.com/syrusakbary/aiodataloader?tab=readme-ov-file#batching explains it quite well.

Assuming we have an async framework based on an event-loop. We can call the async fns, and they will run immediately up until the first await point. So they will observe a bunch of load calls.

On the next tick of the event loop, all the load calls that happened on the previous tick are being batched together and executed as one.

The graphql framework in the background is executing all the resolvers concurrently, meaning all of them are running up until the first await Loader.load(). Then the dataloader does its magic and batches all those load requests together.

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (ab4cb5b) to head (cdbd476).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         487      487              
  Lines       16892    16891       -1     
==========================================
- Hits        16272    16271       -1     
  Misses        620      620              

Flag	Coverage Δ
unit	96.32% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sentry]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ OperationalError: table bundles already exists /graphql/{service} View Issue

_{Did you find this useful? React with a 👍 or 👎}