Skip to content

Commit e7639ed

Browse files
fix: Add upload url validation to upload sender
1 parent 1c20fd4 commit e7639ed

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

codecov-cli/codecov_cli/services/upload/upload_sender.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
from codecov_cli.helpers.config import CODECOV_INGEST_URL
1313
from codecov_cli.helpers.encoder import encode_slug
1414
from codecov_cli.helpers.upload_type import ReportType
15+
from codecov_cli.helpers.upload_url_validation import validate_upload_service
1516
from codecov_cli.helpers.request import (
1617
get_token_header,
1718
send_post_request,
@@ -218,8 +219,11 @@ def get_url_and_possibly_update_data(
218219
upload_coverage=False,
219220
file_not_found=False,
220221
):
222+
service_part = (git_service or "").strip()
223+
221224
if report_type == ReportType.COVERAGE:
222-
base_url = f"{upload_url}/upload/{git_service}/{encoded_slug}"
225+
validate_upload_service(service_part)
226+
base_url = f"{upload_url}/upload/{service_part}/{encoded_slug}"
223227
if upload_coverage:
224228
url = f"{base_url}/upload-coverage"
225229
else:
@@ -228,7 +232,7 @@ def get_url_and_possibly_update_data(
228232
data["slug"] = encoded_slug
229233
data["branch"] = branch
230234
data["commit"] = commit_sha
231-
data["service"] = git_service
235+
data["service"] = service_part if service_part else None
232236
data["file_not_found"] = file_not_found
233237
url = f"{upload_url}/upload/test_results/v1"
234238

0 commit comments

Comments
 (0)