remove exposure logging from Feature

Author: matt-codecov

shared/rollouts/__init__.py

@@ -7,15 +7,11 @@
 import mmh3
 from asgiref.sync import sync_to_async
 from cachetools.func import lru_cache, ttl_cache
-from django.utils import timezone
 
 from shared.config import get_config
 from shared.django_apps.rollouts.models import (
-    FeatureExposure,
     FeatureFlag,
     FeatureFlagVariant,
-    Platform,
-    RolloutUniverse,
 )
 from shared.django_apps.utils.rollout_utils import rollout_universe_to_override_string
 
@@ -309,10 +305,9 @@ def _check_value_no_lru(self, identifier, default):
         the `Feature` class on every request.
         """
 
-        # don't log exposures for flag evaluations from the endpoint
-        return self._check_value_impl(identifier, default, log_exposures=False)
+        return self._check_value_impl(identifier, default)
 
-    def _check_value_impl(self, identifier, default, log_exposures=True):
+    def _check_value_impl(self, identifier, default):
         """
         This is the core logic of how a feature flag variant is assigned to a user based on some identifier, and
         returns the variant's value.
@@ -338,11 +333,6 @@ def _check_value_impl(self, identifier, default, log_exposures=True):
         )
         for bucket_start, bucket_end, variant in self._buckets:
             if bucket_start <= key and key < bucket_end:
-                # only log exposures for backend flags because frontend has no SQL metrics and
-                # flag evaluations should be cached client-side anyways
-                if self.feature_flag.platform == Platform.BACKEND and log_exposures:
-                    self.create_exposure(variant, identifier)
-
                 return variant.value
 
         return default
@@ -357,22 +347,3 @@ def _is_different(self, inst1, inst2):
                 return False
 
         return True
-
-    def create_exposure(self, variant, identifier):
-        """
-        Creates an exposure record indicating that a feature variant has been applied to
-        an entity (repo or owner) at a current point in time. This method should only
-        be used for backend feature flags, as we're only collecting `telemetry_simple`
-        SQL metrics for backend services.
-        """
-        args = {
-            "feature_flag": self.feature_flag,
-            "feature_flag_variant": variant,
-            "timestamp": timezone.now(),
-        }
-        if self.feature_flag.rollout_universe == RolloutUniverse.OWNER_ID:
-            args["owner"] = identifier
-        elif self.feature_flag.rollout_universe == RolloutUniverse.REPO_ID:
-            args["repo"] = identifier
-
-        FeatureExposure.objects.create(**args)

tests/unit/test_rollouts.py

@@ -5,10 +5,8 @@
 from django.test import TestCase
 
 from shared.django_apps.rollouts.models import (
-    FeatureExposure,
     FeatureFlag,
     FeatureFlagVariant,
-    Platform,
     RolloutUniverse,
 )
 from shared.rollouts import Feature
@@ -384,100 +382,3 @@ def test_check_value_with_env_disable_and_env_override(self):
             assert feature.check_value(identifier=1, default=100) == 100
             fetch_fn.assert_not_called()
             assert not hasattr(feature.__dict__, "_buckets")
-
-
-class TestFeatureExposures(TestCase):
-    def test_exposure_created(self):
-        complex = FeatureFlag.objects.create(
-            name="my_feature", proportion=1.0, salt="random_salt"
-        )
-        enabled = FeatureFlagVariant.objects.create(
-            name="enabled", feature_flag=complex, proportion=1.0, value=True
-        )
-        FeatureFlagVariant.objects.create(
-            name="disabled", feature_flag=complex, proportion=0, value=False
-        )
-
-        owner_id = 123123123
-
-        my_feature = Feature("my_feature")
-        my_feature.check_value(identifier=owner_id)
-
-        exposure = FeatureExposure.objects.all().first()
-
-        assert exposure is not None
-        assert exposure.owner == owner_id
-        assert exposure.feature_flag == complex
-        assert exposure.feature_flag_variant == enabled
-
-    def test_exposure_not_created(self):
-        complex = FeatureFlag.objects.create(
-            name="my_feature", proportion=1.0, salt="random_salt"
-        )
-        FeatureFlagVariant.objects.create(
-            name="enabled", feature_flag=complex, proportion=0, value=True
-        )
-
-        with patch.object(Feature, "create_exposure") as create_exposure:
-            owner_id = 123123123
-
-            my_feature = Feature("my_feature")
-            my_feature.check_value(identifier=owner_id)
-
-            exposure = FeatureExposure.objects.first()
-
-            # Should not create an exposure because the owner was not exposed to any
-            # explicit variant, it was assigned the default behaviour
-            assert exposure is None
-            create_exposure.assert_not_called()
-
-    def test_frontend_flag_does_not_log_exposures(self):
-        complex = FeatureFlag.objects.create(
-            name="my_feature",
-            proportion=1.0,
-            salt="random_salt",
-            platform=Platform.FRONTEND,
-        )
-        FeatureFlagVariant.objects.create(
-            name="enabled", feature_flag=complex, proportion=1.0, value=True
-        )
-        FeatureFlagVariant.objects.create(
-            name="disabled", feature_flag=complex, proportion=0, value=False
-        )
-
-        with patch.object(Feature, "create_exposure") as create_exposure:
-            owner_id = 123123123
-
-            my_feature = Feature("my_feature")
-            my_feature.check_value(identifier=owner_id)
-
-            exposure = FeatureExposure.objects.all().first()
-
-            assert exposure is None
-            create_exposure.assert_not_called()
-
-    def test_backend_flag_does_log_exposures(self):
-        complex = FeatureFlag.objects.create(
-            name="my_feature",
-            proportion=1.0,
-            salt="random_salt",
-            platform=Platform.BACKEND,
-        )
-        enabled = FeatureFlagVariant.objects.create(
-            name="enabled", feature_flag=complex, proportion=1.0, value=True
-        )
-        FeatureFlagVariant.objects.create(
-            name="disabled", feature_flag=complex, proportion=0, value=False
-        )
-
-        owner_id = 123123123
-
-        my_feature = Feature("my_feature")
-        my_feature.check_value(identifier=owner_id)
-
-        exposure = FeatureExposure.objects.all().first()
-
-        assert exposure is not None
-        assert exposure.owner == owner_id
-        assert exposure.feature_flag == complex
-        assert exposure.feature_flag_variant == enabled