Skip to content

fix(test_analytics): Resolve N+1 query in flake processing#1205

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/ta-flake-n-plus-1
Open

fix(test_analytics): Resolve N+1 query in flake processing#1205
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/ta-flake-n-plus-1

Conversation

@sentry

@sentry sentry Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query issue identified in app.tasks.flakes.ProcessFlakesTask, specifically within the handle_pass function in apps/worker/services/test_analytics/ta_process_flakes.py.

Root Cause:
Previously, when a flake reached 30 recent passes, handle_pass would call flake.save() individually for each such flake. This resulted in an N+1 query problem, where a separate UPDATE database operation was executed for every expiring flake within the processing loop.

Solution:
To resolve this, the handle_pass function no longer calls flake.save() directly. Instead, expiring flakes are now collected into a list (expired_flakes). After all uploads for a commit have been processed, process_flakes_for_commit performs a single Flake.objects.bulk_update() operation on this collected list. This change batches all updates for expired flakes into a single database query, significantly reducing the number of database interactions and improving performance.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YT9

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (7b60783) to head (f4c54f8).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1205   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50862    50865    +3     
  Branches     1626     1626           
=======================================
+ Hits        46741    46744    +3     
  Misses       3815     3815           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.55% <14.28%> (-0.02%) ⬇️
workerunit 90.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants