perf(worker): Optimize N+1 queries in ProcessFlakesTask#1209
Open
sentry[bot] wants to merge 1 commit into
Open
perf(worker): Optimize N+1 queries in ProcessFlakesTask#1209sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 1325 1325
Lines 50862 50877 +15
Branches 1626 1626
==========================================
+ Hits 46741 46754 +13
- Misses 3815 3817 +2
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the N+1 query issue (WORKER-YTD) identified in
app.tasks.flakes.ProcessFlakesTaskwithinapps/worker/services/test_analytics/ta_process_flakes.py.Problem:
Previously, the
process_flakes_for_commitfunction iterated over each upload, leading to:Testrunobjects for each upload (get_testruns(upload)).Testrun.objects.bulk_updatecall for each upload.flake.save()calls when a flake expired.This resulted in an N+1 query pattern, causing excessive database load and slower processing times proportional to the number of uploads.
Solution:
This change refactors the flake processing logic to batch database operations:
get_testruns_for_uploadsto fetch all relevantTestrunobjects for all uploads in a single query, then groups them byupload_id.process_single_upload: Modified to accept pre-fetchedTestrunobjects and anexpired_flakeslist, removing internal DB queries and individualbulk_updatecalls.TestrunUpdates: All modifiedTestrunobjects from all uploads are now collected and updated in a singleTestrun.objects.bulk_updatecall at the end ofprocess_flakes_for_commit.flake.save()calls for expired flakes are replaced with appending to a list, which is then processed by a singleFlake.objects.bulk_updatecall.Impact:
This significantly reduces the number of database queries from N+1 (where N is the number of uploads) to a constant number of queries, improving the performance and efficiency of the
ProcessFlakesTask.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YTD