fix(test_analytics): Eliminate N+1 queries in flake processing#1210
Open
sentry[bot] wants to merge 1 commit into
Open
fix(test_analytics): Eliminate N+1 queries in flake processing#1210sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue identified in
app.tasks.flakes.ProcessFlakesTask, specifically withinservices/test_analytics/ta_process_flakes.py.Problem:
process_flakes_for_commitwould iterate over eachuploadand callget_testruns(upload), resulting in a separate database query forTestrunobjects for every single upload. This led to an N+1 query pattern where N is the number of uploads.handle_passwould call.save()individually for eachFlakeobject that reached 30 recent passes, leading to multiple single-row updates.Solution:
get_testruns_for_uploadsto fetch all relevantTestrunobjects for all uploads in a single batched query usingupload_id__in. These testruns are then grouped byupload_idand passed toprocess_single_upload.handle_passto collect expiredFlakeobjects into a list. After processing all uploads, these collected flakes are updated in a singleFlake.objects.bulk_updatecall.Impact:
This change significantly reduces the number of database queries executed during flake processing, improving the performance and efficiency of the
ProcessFlakesTask.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YTE