fix(bitbucket): prevent TorngitServerUnreachableError in find_pull_request#1211
Open
sentry[bot] wants to merge 1 commit into
Open
fix(bitbucket): prevent TorngitServerUnreachableError in find_pull_request#1211sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
==========================================
+ Coverage 91.89% 91.91% +0.01%
==========================================
Files 1325 1325
Lines 50862 50853 -9
Branches 1626 1620 -6
==========================================
- Hits 46741 46740 -1
+ Misses 3815 3808 -7
+ Partials 306 305 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
TorngitServerUnreachableErroroccurring in theapp.tasks.notify.Notifytask when interacting with Bitbucket.Root Cause:
The
find_pull_requestfunction inshared/torngit/bitbucket.pywas attempting to find a commit's associated pull request by paginating through all open pull requests for a repository. For repositories with a large number of open PRs (e.g., 25+ pages), this led to making 25+ sequential API calls on the same HTTP connection. Bitbucket's server has a keep-alive limit, causing the connection to be closed after approximately 25 requests. Subsequent requests on the same connection would then fail with aReadError(specificallyanyio.BrokenResourceError), which was broadly caught and re-raised asTorngitServerUnreachableError, masking the true cause of connection exhaustion.Solution:
To resolve this, the
find_pull_requestfunction has been updated to leverage Bitbucket's commit-specific API endpoint (GET /repositories/{slug}/commit/{commit}/pullrequests) when searching for a pull request by commit SHA. This approach:The existing pagination logic is retained only for the less common case of finding a pull request by branch name, where a commit-specific shortcut is not available.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YTF