fix(worker): Resolve N+1 query in ProcessFlakesTask#1212
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 1325 1325
Lines 50862 50874 +12
Branches 1626 1626
==========================================
+ Hits 46741 46750 +9
- Misses 3815 3818 +3
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An N+1 query was identified in
app.tasks.flakes.ProcessFlakesTask, specifically within theprocess_flakes_for_commitfunction. The original implementation iterated over eachuploadand, for each, calledprocess_single_upload. Insideprocess_single_upload, a separate database query was executed to fetchTestrunobjects for that specific upload. This resulted in an N+1 query pattern (1 query for uploads + N queries for testruns).Additionally,
Testrun.objects.bulk_updatewas being called inside the loop for each upload, leading to N separate update operations.This fix addresses the N+1 query by:
get_testruns_for_uploadsto batch-fetch all relevantTestrunobjects for all uploads in a single database query.process_single_uploadto accept pre-fetchedTestrunobjects, eliminating the need for per-upload database queries.Testrun.objects.bulk_updateinto a single call after all uploads have been processed, further optimizing database interactions.These changes significantly reduce the number of database queries and improve the performance of the
ProcessFlakesTask.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YTG