fix(worker): Optimize ProcessFlakesTask N+1 queries for testruns and flakes#1213
Open
sentry[bot] wants to merge 1 commit into
Open
fix(worker): Optimize ProcessFlakesTask N+1 queries for testruns and flakes#1213sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue in the
app.tasks.flakes.ProcessFlakesTaskby optimizing database interactions related toTestrunandFlakeobjects.Problem:
Previously,
process_flakes_for_commitwould iterate over eachReportSession(upload) and:get_testruns(upload)for each upload, resulting in a separate database query forTestrunobjects per upload.Testrun.objects.bulk_updatefor each upload after processing, leading to multiple update operations.handle_pass, individualflake.save()calls were made when a flake expired, causing additional single-row updates.Solution:
get_testruns_for_uploadswas introduced to fetch all relevantTestrunobjects for all uploads in a single batched query. These are then grouped byupload_idin Python.process_single_uploadwas refactored to accept pre-fetched testruns. All modifiedTestrunobjects are now accumulated andTestrun.objects.bulk_updateis called only once after processing all uploads.flake.save()call inhandle_passfor expiring flakes has been removed. Expiring flakes are now marked withend_dateand handled by the existingFlake.objects.bulk_create(update_conflicts=True)operation at the end ofprocess_flakes_for_commit, which efficiently updates or creates flakes in bulk.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YTH